Summary: | Web Inspector: Add inspected node using public console API. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | keishi, timothy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Pavel Feldman
2009-07-28 01:21:53 PDT
Created attachment 33614 [details]
Patch
For some reason half of this was landed. I landed the rest. http://trac.webkit.org/changeset/46516 I think it was landed property and was functioning well. There is nothing wrong in calling private methods within the class/file (WebInspector.Console). It was bad to make calls to Console's internals from ElementsPanel. FYI: As we move towards serialized inspector interaction, JavaScript code will split into 'agent' and 'front-end' components. InspectorCommandLineAPI will belong to the 'agent' part and hence having _addInspectedNode within the InspectorCommandLine API along with the container for these last inspected nodes was actually making sense. I guess what landed wasnt what was attached here. And this bug was still open and waiting to land (so it seemed). So I was confused when it looked like half landed and the bug was still open. I agree, what you landed was fine now that I think about it. (In reply to comment #5) > I agree, what you landed was fine now that I think about it. It looks like some kind of a glitch. I was attaching the original patch under this very bug, landing exactly what I was attaching after you reviewed it. I can't see my attachment anymore. Every time I land I update the bug with the commit record and close it. I can't find it here now. I wonder what could go wrong here. |