Bug 277376

Summary: [JSC] non-unified runtime/CachedBytecode.cpp can't compile after 279198@main
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: JavaScriptCoreAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Fujii Hironori 2024-07-30 14:48:56 PDT 
After 279198@main, "perl ./Tools/Scripts/build-webkit --debug --no-unified-builds" can't compile

[4/9893] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\CachedBytecode.cpp.obj
FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/CachedBytecode.cpp.obj 
C:\PROGRA~1\LLVM\bin\clang-cl.exe  /nologo -TP -DBUILDING_JavaScriptCore -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DHAVE_CONFIG_H=1 -DJavaScriptCore_EXPORTS -DNOCRYPT -DNOMINMAX -DNTDDI_VERSION=0x0A000006 -DPAS_BMALLOC=1 -DUNICODE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x0A00 -D_WINDOWS -D_WINSOCKAPI_="" -IC:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\Headers -IC:\webkit\wb\WebKitBuild\Debug -IC:\webkit\wb\Source\JavaScriptCore -IC:\webkit\wb\Source\JavaScriptCore\API -IC:\webkit\wb\Source\JavaScriptCore\assembler -IC:\webkit\wb\Source\JavaScriptCore\b3 -IC:\webkit\wb\Source\JavaScriptCore\b3\air -IC:\webkit\wb\Source\JavaScriptCore\bindings -IC:\webkit\wb\Source\JavaScriptCore\builtins -IC:\webkit\wb\Source\JavaScriptCore\bytecode -IC:\webkit\wb\Source\JavaScriptCore\bytecompiler -IC:\webkit\wb\Source\JavaScriptCore\dfg -IC:\webkit\wb\Source\JavaScriptCore\disassembler -IC:\webkit\wb\Source\JavaScriptCore\disassembler\ARM64 -IC:\webkit\wb\Source\JavaScriptCore\disassembler\zydis\Zydis -IC:\webkit\wb\Source\JavaScriptCore\domjit -IC:\webkit\wb\Source\JavaScriptCore\ftl -IC:\webkit\wb\Source\JavaScriptCore\fuzzilli -IC:\webkit\wb\Source\JavaScriptCore\heap -IC:\webkit\wb\Source\JavaScriptCore\debugger -IC:\webkit\wb\Source\JavaScriptCore\inspector -IC:\webkit\wb\Source\JavaScriptCore\inspector\agents -IC:\webkit\wb\Source\JavaScriptCore\inspector\augmentable -IC:\webkit\wb\Source\JavaScriptCore\inspector\remote -IC:\webkit\wb\Source\JavaScriptCore\interpreter -IC:\webkit\wb\Source\JavaScriptCore\jit -IC:\webkit\wb\Source\JavaScriptCore\llint -IC:\webkit\wb\Source\JavaScriptCore\parser -IC:\webkit\wb\Source\JavaScriptCore\profiler -IC:\webkit\wb\Source\JavaScriptCore\runtime -IC:\webkit\wb\Source\JavaScriptCore\tools -IC:\webkit\wb\Source\JavaScriptCore\wasm -IC:\webkit\wb\Source\JavaScriptCore\wasm\js -IC:\webkit\wb\Source\JavaScriptCore\yarr -IC:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources -IC:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources\inspector -IC:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources\runtime -IC:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources\yarr -IC:\webkit\wb\Source\JavaScriptCore\inspector\remote\socket -IC:\webkit\wb\WebKitBuild\Debug\WTF\Headers -imsvcC:\webkit\wb\WebKitLibraries\win\include /W4 -fcolor-diagnostics -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-deprecated-declarations -Wno-sign-compare /DWIN32 /D_WINDOWS  -fno-strict-aliasing /Zi /Ob0 /Od /RTC1 -std:c++latest -MD /Zi /GS /EHa- /EHc- /EHs- /fp:except- /GR- /analyze- /bigobj /utf-8 /validate-charset /WX /YuC:/webkit/wb/WebKitBuild/Debug/Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/cmake_pch.hxx /FpC:/webkit/wb/WebKitBuild/Debug/Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/./cmake_pch.cxx.pch /FIC:/webkit/wb/WebKitBuild/Debug/Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/cmake_pch.hxx /showIncludes /FoSource\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\CachedBytecode.cpp.obj /FdSource\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\ -c -- C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp:27:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.h:28:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CacheUpdate.h:29:
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedTypes.h(55,32): error: inline function 'JSC::CachedFunctionExecutableOffsets::codeBlockForCallOffset' is not defined [-Werror,-Wundefined-inline]
   55 |     static constexpr ptrdiff_t codeBlockForCallOffset();
      |                                ^
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp(72,112): note: used here
   72 |                 ptrdiff_t kindOffset = functionUpdate.m_kind == CodeForCall ? CachedFunctionExecutableOffsets::codeBlockForCallOffset() : CachedFunctionExecutableOffsets::codeBlockForConstructOffset();
      |                                                                                                                ^
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp:27:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.h:28:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CacheUpdate.h:29:
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedTypes.h(56,32): error: inline function 'JSC::CachedFunctionExecutableOffsets::codeBlockForConstructOffset' is not defined [-Werror,-Wundefined-inline]
   56 |     static constexpr ptrdiff_t codeBlockForConstructOffset();
      |                                ^
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp(72,172): note: used here
   72 |                 ptrdiff_t kindOffset = functionUpdate.m_kind == CodeForCall ? CachedFunctionExecutableOffsets::codeBlockForCallOffset() : CachedFunctionExecutableOffsets::codeBlockForConstructOffset();
      |                                                                                                                                                                            ^
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp:27:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.h:28:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CacheUpdate.h:29:
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedTypes.h(61,32): error: inline function 'JSC::CachedWriteBarrierOffsets::ptrOffset' is not defined [-Werror,-Wundefined-inline]
   61 |     static constexpr ptrdiff_t ptrOffset();
      |                                ^
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp(73,109): note: used here
   73 |                 ptrdiff_t codeBlockOffset = functionUpdate.m_base + kindOffset + CachedWriteBarrierOffsets::ptrOffset() + CachedPtrOffsets::offsetOffset();
      |                                                                                                             ^
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp:27:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.h:28:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CacheUpdate.h:29:
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedTypes.h(65,32): error: inline function 'JSC::CachedPtrOffsets::offsetOffset' is not defined [-Werror,-Wundefined-inline]
   65 |     static constexpr ptrdiff_t offsetOffset();
      |                                ^
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp(73,141): note: used here
   73 |                 ptrdiff_t codeBlockOffset = functionUpdate.m_base + kindOffset + CachedWriteBarrierOffsets::ptrOffset() + CachedPtrOffsets::offsetOffset();
      |                                                                                                                                             ^
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp:27:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.h:28:
In file included from C:\webkit\wb\Source\JavaScriptCore\runtime\CacheUpdate.h:29:
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedTypes.h(57,32): error: inline function 'JSC::CachedFunctionExecutableOffsets::metadataOffset' is not defined [-Werror,-Wundefined-inline]
   57 |     static constexpr ptrdiff_t metadataOffset();
      |                                ^
C:\webkit\wb\Source\JavaScriptCore\runtime\CachedBytecode.cpp(80,101): note: used here
   80 |                 ptrdiff_t metadataOffset = functionUpdate.m_base + CachedFunctionExecutableOffsets::metadataOffset();
      |                                                                                                     ^
5 errors generated.
[5/9893] Generate bindings (WebCoreBindings)
[6/9893] Generate bindings (WebCoreTestSupportBindings)
ninja: build stopped: cannot make progress due to previous errors.
Comment 1 Fujii Hironori 2024-07-30 15:16:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/31502
Comment 2 EWS 2024-07-31 13:51:05 PDT 
Committed 281670@main (c773df72044f): <https://commits.webkit.org/281670@main>

Reviewed commits have been landed. Closing PR #31502 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-07-31 13:52:15 PDT 
<rdar://problem/132928098>