Bug 277311
| Summary: | webkitpy.common.checkout.scm.git should call git-clone with ignore-errors=False | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | destra, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
rdar://132760981
From that Radar:
> For example, when my network connection failed today while I was running import-w3c-tests, I only saw the error “no such file or directory,” which made it harder to diagnose that it was a network problem that was making git-clone fail.
and
> For clone, this goes back to when it was added in https://commits.webkit.org/186382@main. It’s unclear to me when why we would want it to be fallible by default?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/31434
EWS
Committed 281847@main (1273989bf667): <https://commits.webkit.org/281847@main>
Reviewed commits have been landed. Closing PR #31434 and removing active labels.