Bug 27731

Summary:

[V8] Implement EventListener::reportError for V8 event listeners in worker context.

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore Misc.

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

Attachments:

Description	Flags
Proposed Patch	levin: review+

Jian Li

Reported 2009-07-27 13:30:13 PDT

Implement EventListener::reportError for V8 event listeners in worker context.

Attachments
Proposed Patch (3.95 KB, patch) 2009-07-27 13:35 PDT, Jian Li	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jian Li

Comment 1 2009-07-27 13:35:19 PDT

Created attachment 33567 [details] Proposed Patch

David Levin

Comment 2 2009-07-27 18:04:19 PDT

Comment on attachment 33567 [details] Proposed Patch > diff --git a/WebCore/bindings/v8/V8WorkerContextEventListener.cpp b/WebCore/bindings/v8/V8WorkerContextEventListener.cpp > + // The callback function on XMLHttpRequest can clear the event listener and destroys 'this' object. Keep a local reference to it. I'd get rid of "on XMLHttpRequest" and change "destroys" to "destroy". > + // See issue 889829. I'd remove this issue number here.

Jian Li

Comment 3 2009-07-27 18:12:18 PDT

Committed as http://trac.webkit.org/changeset/46448

Note You need to log in before you can comment on or make changes to this bug.