Bug 277288
| Summary: | Adding Glyph display list COLRv0 shared test | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vitor Roriz <vitor.roriz> |
| Component: | Text | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fantasai.bugs, vitor.roriz, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vitor Roriz
LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-unshared.html tests that COLRv0 are not cached.
However, after a CoreText update, WebKit had to introduce drawPath delegates for DrawGlyphsRecorderCoreText.cpp. The glyphs that are drawn as a path, and not as a glyph, by CoreText, were failing this test, because they were sharing the same display list, which seems to indicate they can be cached.
Since this test is covering the unshared behavior, we should have another test for shared behavior. Another option would be to rename this test and cover both distinct behaviors on it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Vitor Roriz
<rdar://problem/117866670>
Vitor Roriz
Pull request: https://github.com/WebKit/WebKit/pull/31414
EWS
Committed 281533@main (af007e7018ef): <https://commits.webkit.org/281533@main>
Reviewed commits have been landed. Closing PR #31414 and removing active labels.