Bug 277234
| Summary: | http/tests/canvas/ctx.2d-canvas-style-no-document-leak.html is flaky failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <fujii.hironori> |
| Component: | Tools / Tests | Assignee: | Ryan Reno <rreno> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rreno, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=256262 https://bugs.webkit.org/show_bug.cgi?id=277263 |
||
Fujii Hironori
http/tests/canvas/ctx.2d-canvas-style-no-document-leak.html is flaky failure
History:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fcanvas%2Fctx.2d-canvas-style-no-document-leak.html
Buildbot: builder Apple-Sonoma-Release-WK2-Tests build 2831 : 278780@main
https://build.webkit.org/#/builders/926/builds/2831
https://build.webkit.org/results/Apple-Sonoma-Release-WK2-Tests/278780@main%20(2831)/http/tests/canvas/ctx.2d-canvas-style-no-document-leak-diff.txt
--- /Volumes/Data/worker/Apple-Sonoma-Release-WK2-Tests/build/layout-test-results/http/tests/canvas/ctx.2d-canvas-style-no-document-leak-expected.txt
+++ /Volumes/Data/worker/Apple-Sonoma-Release-WK2-Tests/build/layout-test-results/http/tests/canvas/ctx.2d-canvas-style-no-document-leak-actual.txt
@@ -6,7 +6,7 @@
PASS internals.isDocumentAlive(frameDocumentID) is true
PASS internals.isDocumentAlive(frameDocumentID) is true
PASS internals.isDocumentAlive(frameDocumentID) is true
-PASS The iframe document didn't leak.
+FAIL The iframe document leaked.
PASS successfullyParsed is true
TEST COMPLETE
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
This test was added by 263774@main.
Fujii Hironori
This test case has only a single iframe. It should create more iframes like document-leak-test.js does.
Ryan Reno
Yes, this test should be rewritten to use the document-leak-test.js helper. I'll put a patch up for review shortly. Thanks for catching that. There's a couple of other tests I can rewrite - the one for ReportingObserver callbacks (which is where document-leak-test.js was adopted from), geolocation callbacks, and probably the one for MediaSession Action Handlers.
Radar WebKit Bug Importer
<rdar://problem/132725257>
Ryan Reno
Pull request: https://github.com/WebKit/WebKit/pull/31395
EWS
Committed 281523@main (148e56013b45): <https://commits.webkit.org/281523@main>
Reviewed commits have been landed. Closing PR #31395 and removing active labels.