Bug 277166
| Summary: | [GTK4] Several Window object related tests are failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | Page Loading | Assignee: | Lauro Moura <lmoura> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego Pino
There are several layout-tests related to Window object that are failing in GTK4, but not GTK3.
The tests are the following:
- fast/dom/Window/window-focus-self.html
https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/281403%40main%20%2833519%29/fast/dom/Window/window-focus-self-diff.txt
```
--- /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/fast/dom/Window/window-focus-self-expected.txt
+++ /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/fast/dom/Window/window-focus-self-actual.txt
@@ -1,2 +1,2 @@
This tests that a window cannot focus itself by using javascript: urls.
-Window was blurred
+
```
- fast/dom/Window/window-resize-and-move-arguments.html
https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/281403%40main%20%2833519%29/fast/dom/Window/window-resize-and-move-arguments-diff.txt
```
--- /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/fast/dom/Window/window-resize-and-move-arguments-expected.txt
+++ /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/fast/dom/Window/window-resize-and-move-arguments-actual.txt
@@ -43,8 +43,8 @@
PASS window.screenX is resetX
PASS window.screenY is resetY
Testing - moveTo with more than 2 arguments
-PASS window.screenX is x + screen.availLeft
-PASS window.screenY is y + screen.availTop
+FAIL window.screenX should be 25. Was 0.
+FAIL window.screenY should be 50. Was 0.
window.moveBy Tests
@@ -57,9 +57,10 @@
PASS window.screenX is resetX
PASS window.screenY is resetY
Testing - moveBy with more than 2 arguments
-PASS window.screenX is resetX + x
-PASS window.screenY is resetY + y
+FAIL window.screenX should be 25. Was 0.
+FAIL window.screenY should be 50. Was 0.
PASS successfullyParsed is true
+Some tests failed.
TEST COMPLETE
```
- fast/dom/Window/window-resize.html
https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/281403%40main%20%2833519%29/fast/dom/Window/window-resize-diff.txt
--- /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/fast/dom/Window/window-resize-expected.txt
+++ /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/fast/dom/Window/window-resize-actual.txt
@@ -19,8 +19,8 @@
PASS window.outerWidth is screen.availWidth
Testing - resizeTo: Not Full Screen Out of Bounds
-PASS window.outerHeight + window.screenY - screen.availTop is screen.availHeight
-PASS window.outerWidth + window.screenX - screen.availLeft is screen.availWidth
+FAIL window.outerHeight + window.screenY - screen.availTop should be 768. Was 394.
+FAIL window.outerWidth + window.screenX - screen.availLeft should be 1024. Was 800.
window.resizeBy Tests
@@ -71,12 +71,12 @@
PASS window.screenY == previousScreenY is true
Testing - moveBy: One Zero
-PASS window.screenX == previousScreenX + 1 is true
+FAIL window.screenX == previousScreenX + 1 should be true. Was false.
PASS window.screenY == previousScreenY is true
Testing - moveBy: Zero One
PASS window.screenX == previousScreenX is true
-PASS window.screenY == previousScreenY + 1 is true
+FAIL window.screenY == previousScreenY + 1 should be true. Was false.
Testing - moveBy: Top Left
PASS window.screenY is screen.availTop
```
- imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-left.html
https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/281403%40main%20%2833519%29/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-left-diff.txt
```
--- /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-left-expected.txt
+++ /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-left-actual.txt
@@ -2,13 +2,13 @@
PASS features "left=/104" should NOT set "left=104"
PASS features "left=_104" should NOT set "left=104"
PASS features "left=L104" should NOT set "left=104"
-PASS features "left=105.5" should set "left=105"
-PASS features "left=105.32" should set "left=105"
-PASS features "left=105LLl" should set "left=105"
-PASS features "left=105^4" should set "left=105"
-PASS features "left=105*3" should set "left=105"
-PASS features "left=105/5" should set "left=105"
-PASS features "left=105 " should set "left=105"
-PASS features "left=105e1" should set "left=105"
-PASS features "left=105e-1" should set "left=105"
+FAIL features "left=105.5" should set "left=105" assert_equals: "width=401,height=204,top=0,left=105.5 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "left=105.32" should set "left=105" assert_equals: "width=401,height=204,top=0,left=105.32 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "left=105LLl" should set "left=105" assert_equals: "width=401,height=204,top=0,left=105LLl value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "left=105^4" should set "left=105" assert_equals: "width=401,height=204,top=0,left=105^4 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "left=105*3" should set "left=105" assert_equals: "width=401,height=204,top=0,left=105*3 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "left=105/5" should set "left=105" assert_equals: "width=401,height=204,top=0,left=105/5 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "left=105 " should set "left=105" assert_equals: "width=401,height=204,top=0,left=105 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "left=105e1" should set "left=105" assert_equals: "width=401,height=204,top=0,left=105e1 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "left=105e-1" should set "left=105" assert_equals: "width=401,height=204,top=0,left=105e-1 value after first non-digit will be ignored" expected 105 but got 0
```
- imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx.html
https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/281403%40main%20%2833519%29/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx-diff.txt
```
--- /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx-expected.txt
+++ /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-screenx-actual.txt
@@ -2,13 +2,13 @@
PASS features "screenx=/104" should NOT set "screenx=104"
PASS features "screenx=_104" should NOT set "screenx=104"
PASS features "screenx=L104" should NOT set "screenx=104"
-PASS features "screenx=105.5" should set "screenx=105"
-PASS features "screenx=105.32" should set "screenx=105"
-PASS features "screenx=105LLl" should set "screenx=105"
-PASS features "screenx=105^4" should set "screenx=105"
-PASS features "screenx=105*3" should set "screenx=105"
-PASS features "screenx=105/5" should set "screenx=105"
-PASS features "screenx=105 " should set "screenx=105"
-PASS features "screenx=105e1" should set "screenx=105"
-PASS features "screenx=105e-1" should set "screenx=105"
+FAIL features "screenx=105.5" should set "screenx=105" assert_equals: "width=401,height=204,top=0,screenx=105.5 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "screenx=105.32" should set "screenx=105" assert_equals: "width=401,height=204,top=0,screenx=105.32 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "screenx=105LLl" should set "screenx=105" assert_equals: "width=401,height=204,top=0,screenx=105LLl value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "screenx=105^4" should set "screenx=105" assert_equals: "width=401,height=204,top=0,screenx=105^4 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "screenx=105*3" should set "screenx=105" assert_equals: "width=401,height=204,top=0,screenx=105*3 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "screenx=105/5" should set "screenx=105" assert_equals: "width=401,height=204,top=0,screenx=105/5 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "screenx=105 " should set "screenx=105" assert_equals: "width=401,height=204,top=0,screenx=105 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "screenx=105e1" should set "screenx=105" assert_equals: "width=401,height=204,top=0,screenx=105e1 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "screenx=105e-1" should set "screenx=105" assert_equals: "width=401,height=204,top=0,screenx=105e-1 value after first non-digit will be ignored" expected 105 but got 0
```
- imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-top.html
https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/281403%40main%20%2833519%29/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-top-diff.txt
```
--- /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-top-expected.txt
+++ /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-non-integer-top-actual.txt
@@ -2,13 +2,13 @@
PASS features "top=/104" should NOT set "top=104"
PASS features "top=_104" should NOT set "top=104"
PASS features "top=L104" should NOT set "top=104"
-PASS features "top=105.5" should set "top=105"
-PASS features "top=105.32" should set "top=105"
-PASS features "top=105LLl" should set "top=105"
-PASS features "top=105^4" should set "top=105"
-PASS features "top=105*3" should set "top=105"
-PASS features "top=105/5" should set "top=105"
-PASS features "top=105 " should set "top=105"
-PASS features "top=105e1" should set "top=105"
-PASS features "top=105e-1" should set "top=105"
+FAIL features "top=105.5" should set "top=105" assert_equals: "top=105.5 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "top=105.32" should set "top=105" assert_equals: "top=105.32 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "top=105LLl" should set "top=105" assert_equals: "top=105LLl value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "top=105^4" should set "top=105" assert_equals: "top=105^4 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "top=105*3" should set "top=105" assert_equals: "top=105*3 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "top=105/5" should set "top=105" assert_equals: "top=105/5 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "top=105 " should set "top=105" assert_equals: "top=105 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "top=105e1" should set "top=105" assert_equals: "top=105e1 value after first non-digit will be ignored" expected 105 but got 0
+FAIL features "top=105e-1" should set "top=105" assert_equals: "top=105e-1 value after first non-digit will be ignored" expected 105 but got 0
```
- imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-tokenization-screenx-screeny.html
https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/281403%40main%20%2833519%29/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-tokenization-screenx-screeny-diff.txt
```
--- /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-tokenization-screenx-screeny-expected.txt
+++ /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-tokenization-screenx-screeny-actual.txt
@@ -1,16 +1,16 @@
-PASS "screenx=141" should set left position of opened window
-PASS " screenx = 141" should set left position of opened window
-PASS "screenx==141" should set left position of opened window
-PASS "\nscreenx= 141" should set left position of opened window
-PASS ",screenx=141,," should set left position of opened window
-PASS "SCREENX=141" should set left position of opened window
-PASS "screenX=141" should set left position of opened window
-PASS "screeny=142" should set top position of opened window
-PASS " screeny = 142" should set top position of opened window
-PASS "screeny==142" should set top position of opened window
-PASS "\nscreeny= 142" should set top position of opened window
-PASS ",screeny=142,," should set top position of opened window
-PASS "SCREENY=142" should set top position of opened window
-PASS "screenY=142" should set top position of opened window
+FAIL "screenx=141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL " screenx = 141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL "screenx==141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL "\nscreenx= 141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL ",screenx=141,," should set left position of opened window assert_equals: expected 141 but got 0
+FAIL "SCREENX=141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL "screenX=141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL "screeny=142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL " screeny = 142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL "screeny==142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL "\nscreeny= 142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL ",screeny=142,," should set top position of opened window assert_equals: expected 142 but got 0
+FAIL "SCREENY=142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL "screenY=142" should set top position of opened window assert_equals: expected 142 but got 0
```
- imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-tokenization-top-left.html
https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/281403%40main%20%2833519%29/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-tokenization-top-left-diff.txt
```
--- /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-tokenization-top-left-expected.txt
+++ /home/buildbot/worker/GTK-Linux-64-bit-Release-GTK4-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/open-features-tokenization-top-left-actual.txt
@@ -1,19 +1,19 @@
-PASS "left=141" should set left position of opened window
-PASS " left = 141" should set left position of opened window
-PASS "left==141" should set left position of opened window
-PASS "
-left= 141" should set left position of opened window
-PASS ",left=141,," should set left position of opened window
-PASS "LEFT=141" should set left position of opened window
-PASS "top=142" should set top position of opened window
-PASS " top = 142" should set top position of opened window
-PASS "top==142" should set top position of opened window
-PASS "\ttop= 142" should set top position of opened window
-PASS ",top=142,," should set top position of opened window
-PASS "TOP=142" should set top position of opened window
-PASS "top=152,left=152" should set top and left position of opened window
-PASS "top=152,,left=152," should set top and left position of opened window
-PASS "top=152==left=152" should set top and left position of opened window
-PASS ",,top= 152, left=152" should set top and left position of opened window
+FAIL "left=141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL " left = 141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL "left==141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL "
+left= 141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL ",left=141,," should set left position of opened window assert_equals: expected 141 but got 0
+FAIL "LEFT=141" should set left position of opened window assert_equals: expected 141 but got 0
+FAIL "top=142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL " top = 142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL "top==142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL "\ttop= 142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL ",top=142,," should set top position of opened window assert_equals: expected 142 but got 0
+FAIL "TOP=142" should set top position of opened window assert_equals: expected 142 but got 0
+FAIL "top=152,left=152" should set top and left position of opened window assert_equals: expected 152 but got 0
+FAIL "top=152,,left=152," should set top and left position of opened window assert_equals: expected 152 but got 0
+FAIL "top=152==left=152" should set top and left position of opened window assert_equals: expected 152 but got 0
+FAIL ",,top= 152, left=152" should set top and left position of opened window assert_equals: expected 152 but got 0
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/59861
EWS
Test gardening commit 308623@main (91e7710c1933): <https://commits.webkit.org/308623@main>
Reviewed commits have been landed. Closing PR #59861 and removing active labels.