Bug 27707

Summary: [WML] History handling / page cache / loading is buggy and depends on several hacks
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: WebCore Misc.Assignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: staikos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20393    
Attachments:
Description Flags
Initial patch staikos: review+

Nikolas Zimmermann
Reported 2009-07-27 05:08:19 PDT
As the summary says the whole WML loading / page cache / history handling is flawed. It depends on several hacks in FrameLoader / WMLGoElement / WMLCardElement / WMLPageState. * There should be no need to track the history length on our own * <go> / <a> / <anchor> / <do> / <prev> shouldn't need to deal with the FrameLoader directly (currently setting setForceReloadWmlDeck() * FrameLoader needs to detect WML documents and handle them approriate (always reload, no caching, etc.) The tricky part is detecting our layout tests which embed WML content in a XHTML document (which is really 'hacky', but needed for our automatic testing facilities). Fixing these issues should stabilize the loading area between running the layout tests standalone in DRT and using WML docs directly. Uploading a patch with new testcases soon.
Attachments
Initial patch (24.68 KB, patch)
2009-07-27 09:46 PDT, Nikolas Zimmermann 		staikos: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2009-07-27 09:46:27 PDT
Created attachment 33553 [details] Initial patch
Nikolas Zimmermann
Comment 2 2009-07-27 10:04:53 PDT
Landed in r46418.
Note You need to log in before you can comment on or make changes to this bug.