Bug 27704

Summary: Refactor the first step of layout in RenderFlexibleBox.cpp
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: CSSAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 eric: review+

Shinichiro Hamaji
Reported 2009-07-27 03:16:35 PDT
The first steps of RenderFlexibleBox::layoutHorizontalBox and RenderFlexibleBox::layoutVerticalBox are identical. We may be able to factor the code out to reduce duplication.
Attachments
Patch v1 (4.63 KB, patch)
2009-07-27 03:18 PDT, Shinichiro Hamaji 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2009-07-27 03:18:24 PDT
Created attachment 33529 [details] Patch v1 --- 2 files changed, 44 insertions(+), 41 deletions(-)
Eric Seidel (no email)
Comment 2 2009-07-28 10:54:29 PDT
Comment on attachment 33529 [details] Patch v1 It's difficult to read the diff, but this looks right. Looks like you're just sharing code between two functions which should have been shared long ago!
David Levin
Comment 3 2009-07-29 00:22:23 PDT
Assigned to levin for landing.
David Levin
Comment 4 2009-07-29 01:10:04 PDT
Committed as http://trac.webkit.org/changeset/46525
Note You need to log in before you can comment on or make changes to this bug.