Bug 276796
| Summary: | [Flex] Perform more precise invalidation of flex items with percent logical height | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/web-platform-tests/wpt/pull/51431 | ||
Sammy Gill
Currently in updateFlexItemDirtyBitsBeforeLayout, which gets called in RenderFlexibleBox::layoutAndPlaceFlexItems, we will invalidate a clean flex item if one of its logical height properties is percent based. We can make this invalidation more precise by trying to determine if an undamaged item will end up having the same value for its logical height
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/132034177>
Sammy Gill
Pull request: https://github.com/WebKit/WebKit/pull/30979
EWS
Committed 292314@main (8e50dd5daa89): <https://commits.webkit.org/292314@main>
Reviewed commits have been landed. Closing PR #30979 and removing active labels.
Sammy Gill
WPT export: https://github.com/web-platform-tests/wpt/pull/51431