Bug 276734
| Summary: | [JSC] Debug build fails to compile when JIT_OPERATION_VALIDATION is disabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Trivial | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcus Plutowski
rdar://131950848
If you try to compile JSC in debug with JIT_OPERATION_VALIDATION forced to 0, some portions of the feature still compile (and therefore throw errors) because JIT_OPERATION_VALIDATION_ASSERT_ENABLED currently only checks ASSERT_ENABLED.
At one point it was gated by ENABLE(JIT_OPERATION_VALIDATION), so this was not the case, but since then that gate was weakened and changed to `#if ENABLE(JIT_OPERATION_VALIDATION) || ENABLE(JIT_OPERATION_DISASSEMBLY)`. As such, JIT_OPERATION_VALIDATION_ASSERT_ENABLED should explicitly check for JIT_OPERATION_VALIDATION to ensure it’s not turned on when not requested.
This is helpful for debugging.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/30919
EWS
Committed 281070@main (292ee2d452da): <https://commits.webkit.org/281070@main>
Reviewed commits have been landed. Closing PR #30919 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/131967366>