Bug 27661

Summary: Move more callers to using 3 argument toJS
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 27634    
Attachments:
Description Flags
patch abarth: review+

Eric Seidel (no email)
Reported 2009-07-24 12:10:52 PDT
Move more callers to using 3 argument toJS Going to start with the ones for which I'm not changing any behavior (because I don't know how to reliably get the right global object).
Attachments
patch (9.04 KB, patch)
2009-07-24 12:18 PDT, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-07-24 12:18:13 PDT
Created attachment 33460 [details] patch
Adam Barth
Comment 2 2009-07-24 12:24:42 PDT
Comment on attachment 33460 [details] patch I, for one, welcome our new deprecatedGlobalObjectForPrototype overlords.
Eric Seidel (no email)
Comment 3 2009-07-24 12:28:06 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/js/JSCustomPositionCallback.cpp M WebCore/bindings/js/JSCustomPositionErrorCallback.cpp M WebCore/bindings/js/JSCustomSQLStatementCallback.cpp M WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp M WebCore/bindings/js/JSCustomSQLTransactionCallback.cpp M WebCore/bindings/js/JSCustomSQLTransactionErrorCallback.cpp M WebCore/bindings/js/JSNodeFilterCondition.cpp M WebCore/bindings/js/JSWorkerConstructor.cpp Committed r46370 M WebCore/ChangeLog M WebCore/bindings/js/JSWorkerConstructor.cpp M WebCore/bindings/js/JSCustomSQLTransactionCallback.cpp M WebCore/bindings/js/JSCustomPositionErrorCallback.cpp M WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp M WebCore/bindings/js/JSCustomPositionCallback.cpp M WebCore/bindings/js/JSCustomSQLStatementCallback.cpp M WebCore/bindings/js/JSNodeFilterCondition.cpp M WebCore/bindings/js/JSCustomSQLTransactionErrorCallback.cpp r46370 = 387f7b01375536d52ff16937762ec73122e0329c (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46370
Note You need to log in before you can comment on or make changes to this bug.