Bug 276506
| Summary: | results.html fails to find actual/expected/etc. files for tests with percent-encoded names | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
e.g., we see 404 errors when trying to view the diff of `imported/w3c/web-platform-tests/xhr/xmlhttprequest-timeout-abortedonmain.html?aborted%20after%20TIME_DELAY`, because it's trying to load xmlhttprequest-timeout-abortedonmain_aborted%20after%20TIME_DELAY-pretty-diff.html rather than xmlhttprequest-timeout-abortedonmain_aborted%2520after%2520TIME_DELAY-pretty-diff.html (note the percents being encoded as %25, because the filename on disk includes literal percents)
rdar://131409141
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/30716
EWS
Committed 280881@main (99cb6b1f2f9e): <https://commits.webkit.org/280881@main>
Reviewed commits have been landed. Closing PR #30716 and removing active labels.