Bug 276358
Summary: | margin and preferred width calculation for MathML elements | ||
---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> |
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ahmad.saleem792, webkit-bug-importer, zalan |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 276169, 276413 |
Frédéric Wang (:fredw)
Many "preferred width" tests are failing for margin-002/margin-003 (from imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/), even if the block size, inline size and coordinates are correct. I guess the problem is that the margins are not set when computePreferredLogicalWidths() (for layoutBlock() this is done by recomputeLogicalWidth() IIUC). Need to debug a bit what's happening here.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Frédéric Wang (:fredw)
This is likely the reason why LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-border-margin-001.html is failing too, the size and rendering of the `<mrow>` and `<math>` elements are correct and the block size of the `<div>` container is good. However, the inline margins don't seem to taken into account for the inline size of the `<div>`.
Frédéric Wang (:fredw)
Pull request: https://github.com/WebKit/WebKit/pull/30604
Ahmad Saleem
@Alan - from Comment 1 - is it using IFC as well for MathML?
EWS
Committed 280810@main (9a8589b0774a): <https://commits.webkit.org/280810@main>
Reviewed commits have been landed. Closing PR #30604 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/131447182>