Bug 27617

Summary:

WebCore/page/DOMSelection.cpp/h does not conform to style standards

Product:

WebKit

Reporter:

Mike Fenton <mifenton>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, manyoso

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Style patch for DomSelectionPatch.cpp/h	eric: review+

Mike Fenton

Reported 2009-07-23 12:28:40 PDT

cpplint reports a number of valid style fixes that should be made to WebCore/page/DOMSelection.cpp/h.

Attachments
Style patch for DomSelectionPatch.cpp/h (3.23 KB, patch) 2009-07-23 12:30 PDT, Mike Fenton	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mike Fenton

Comment 1 2009-07-23 12:30:44 PDT

Created attachment 33352 [details] Style patch for DomSelectionPatch.cpp/h

Eric Seidel (no email)

Comment 2 2009-07-23 23:12:55 PDT

Comment on attachment 33352 [details] Style patch for DomSelectionPatch.cpp/h LGTM.

Adam Barth

Comment 3 2009-07-23 23:56:29 PDT

Will land.

Adam Barth

Comment 4 2009-07-24 00:42:50 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/DOMSelection.cpp M WebCore/page/DOMSelection.h Committed r46327 M LayoutTests/ChangeLog A LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt A LayoutTests/fast/dom/resources/constructed-objects-prototypes.js A LayoutTests/fast/dom/constructed-objects-prototypes.html r46326 = a4f0bad652e9c44c3450984172bec715dcf6f218 (trunk) M WebCore/ChangeLog M WebCore/page/DOMSelection.h M WebCore/page/DOMSelection.cpp r46327 = 807a99d3bc7b76b71c8d0f1bb0734a49068e5e77 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46327

Note You need to log in before you can comment on or make changes to this bug.