Fix false positives for switch statement indentation check in cpplint

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jakob Petsovits]

Mike Fenton brought to my attention that code like the following throws an indentation warning in cpplint:

switch (blah) {
default: break;
}

As far as I can see, the styleguide doesn't specifically allow these kinds of one-liners, but it also doesn't forbid them. And anyways, the error message for the indentation check would be wrong in this case anyways:

"A case label should not be indented, but line up with its switch statement."

The patch below fixes this issues by making the case label regex more permissive (hm... deja-vu?). It also adds more testcases and only ends the check when the (supposed) closing brace for the switch is actually on the same level of indentation as the switch statement itself. And a slight restructuring of comments and (el)ifs for better readability.

[Jakob Petsovits]

Created attachment 33354 [details]
Fix false positives for switch statement indentation check in cpplint

[David Levin]

I haven't looked at the patch in depth yet... but it feels like the it should be not only "return" but also "break" or even "continue". I think the intent is to not put an "else" if you don't need to.

Ironic, huh ? :)

[Adam Treat]

Landed with r46294.