Bug 276098
| Summary: | [WPE][cross-toolchain-helper] Fix issue with the icu installation and long paths | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=276030 https://unicode-org.atlassian.net/browse/ICU-22813 https://github.com/unicode-org/icu/pull/3058 |
||
Carlos Alberto Lopez Perez
There is a bug libicu that causes libicu to be installed incorrectly when the build system uses long paths (around 500 or more chars).
This was reported to icu here https://unicode-org.atlassian.net/browse/ICU-22813 and also summitted a PR here https://github.com/unicode-org/icu/pull/3058
The issue ended causing that nodejs couldn't run properly on the build system because icu was unproperly installed, making the chromium build fail which was introduced in 280438@main
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
The buildbots have a basepath larger than any developer machine. For example "/home/buildbot/worker/WPE-Linux-RPi4-64bits-Mesa-Release-Perf-Build/build" and that explains why this wasn't caught before.
Carlos Alberto Lopez Perez
Example of failed build: https://build.webkit.org/#/builders/894/builds/12478
There you can see nodejs throwing an error related to ICU
| RuntimeError: Command '/home/buildbot/worker/WPE-Linux-RPi4-64bits-Mesa-Release-Perf-Build/build/WebKitBuild/CrossToolChains/rpi4-64bits-mesa/build/tmp/work/cortexa72-poky-linux/chromium-ozone-wayland/124.0.6367.207/chromium-124.0.6367.207/out/Release/../../third_party/node/linux
| /home/buildbot/worker/WPE-Linux-RPi4-64bits-Mesa-Release-Perf-Build/build/WebKitBuild/CrossToolChains/rpi4-64bits-mesa/build/tmp/work/cortexa72-poky-linux/chromium-ozone-wayland/124.0.6367.207/chromium-124.0.6367.207/third_party/devtools-frontend/src/node_modules/glob/common.js:1
| return a.localeCompare(b, 'en')
| ^
|
| RangeError: Internal error. Icu error.
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/30364
EWS
Committed 280556@main (745d34f6850a): <https://commits.webkit.org/280556@main>
Reviewed commits have been landed. Closing PR #30364 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/130926997>