WebCore/Kit has a few places that don't gracefully handle a null request returned from willSendRequest

• Component: Page Loading
• Status: RESOLVED FIXED

[Brady Eidson]

WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.

-Windows' WebFrameLoaderClient.cpp doesn't expect it as a return value
-ResourceHandleCFNet.cpp doesn't respect it.
-InspectorController.cpp chokes on the next load after a load is cancelled this way.

[Brady Eidson]

Created attachment 33314 [details]
Proposed fix

[Geoffrey Garen]

Comment on attachment 33314 [details]
Proposed fix

Can you add a test for this? For example, could we configure the DRT resource load delegate to return null when asked to?

[Brady Eidson]

Yah, that should be pretty easy.

I love it when the layout test work is substantially more than the patch itself  ;)

I'll do that in the A.M. then attach a new patch.

[Brady Eidson]

Created attachment 33403 [details]
DRT enhancements and layout test

[Geoffrey Garen]

Comment on attachment 33403 [details]
DRT enhancements and layout test

A patch is temporary. A layout test is forever! :)

[Brady Eidson]

Sending        LayoutTests/ChangeLog
Adding         LayoutTests/http/tests/misc/resources/redirect-to-http-url.php
Adding         LayoutTests/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt
Adding         LayoutTests/http/tests/misc/will-send-request-returns-null-on-redirect.html
Sending        LayoutTests/platform/gtk/Skipped
Sending        LayoutTests/platform/qt/Skipped
Sending        WebCore/ChangeLog
Sending        WebCore/inspector/InspectorController.cpp
Sending        WebCore/platform/network/cf/ResourceHandleCFNet.cpp
Sending        WebKit/win/ChangeLog
Sending        WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/DumpRenderTree/LayoutTestController.cpp
Sending        WebKitTools/DumpRenderTree/LayoutTestController.h
Sending        WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
Sending        WebKitTools/DumpRenderTree/mac/ResourceLoadDelegate.mm
Sending        WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.cpp
Transmitting file data .................
Committed revision 46308.