Bug 27588 – Make most DOMObjects hold onto a JSDOMGlobalObject*

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Make most DOMObjects hold onto a JSDOMGlobalObject*

The only exceptions are the SVG objects.

[Eric Seidel (no email)]

Created attachment 33309 [details]
patch

[Eric Seidel (no email)]

I think Sam already got email about this through the bug relationships.  But just in case, I'll CC him.  This is a rather large change (although very little functional change) and I want to make sure folks have plenty of time to digest it. :)

[Adam Barth]

Can we avoid the const_casts?  Those are super ugly.

[Eric Seidel (no email)]

I mentioned to Adam over chat:  The large test I added has *no* functional changes from before and after this patch.  It was written to catch anything that might have changed by this patch, but in the end, there was only one functional change from this patch, which i already covered by the existing tests.  I could/should separate out the large test out of this patch and land it first. :)

[Eric Seidel (no email)]

I've now broken the new test out into its own bug, bug 27622.  I'll post a new patch shortly.

[Eric Seidel (no email)]

Created attachment 33366 [details]
Just the code changes


---
 17 files changed, 147 insertions(+), 43 deletions(-)

[Adam Barth]

Comment on attachment 33366 [details]
Just the code changes

After some clarifying questions via chat, I believe this patch is correct.

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/dom/prototype-inheritance-2-expected.txt
	M	LayoutTests/fast/dom/prototype-inheritance-expected.txt
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/DOMObjectWithSVGContext.h
	M	WebCore/bindings/js/JSDOMBinding.h
	M	WebCore/bindings/js/JSDOMGlobalObject.h
	M	WebCore/bindings/js/JSDOMWindowCustom.cpp
	M	WebCore/bindings/js/JSDocumentCustom.cpp
	M	WebCore/bindings/js/JSHTMLAllCollection.h
	M	WebCore/bindings/js/JSHTMLCollectionCustom.cpp
	M	WebCore/bindings/js/JSHTMLFormElementCustom.cpp
	M	WebCore/bindings/js/JSNamedNodesCollection.cpp
	M	WebCore/bindings/js/JSNamedNodesCollection.h
	M	WebCore/bindings/js/JSSharedWorkerConstructor.cpp
	M	WebCore/bindings/js/JSSharedWorkerConstructor.h
	M	WebCore/bindings/scripts/CodeGeneratorJS.pm
Committed r46320
	M	WebCore/ChangeLog
	M	WebCore/bindings/scripts/CodeGeneratorJS.pm
	M	WebCore/bindings/js/JSSharedWorkerConstructor.h
	M	WebCore/bindings/js/DOMObjectWithSVGContext.h
	M	WebCore/bindings/js/JSSharedWorkerConstructor.cpp
	M	WebCore/bindings/js/JSHTMLCollectionCustom.cpp
	M	WebCore/bindings/js/JSDOMGlobalObject.h
	M	WebCore/bindings/js/JSNamedNodesCollection.cpp
	M	WebCore/bindings/js/JSHTMLFormElementCustom.cpp
	M	WebCore/bindings/js/JSDOMBinding.h
	M	WebCore/bindings/js/JSNamedNodesCollection.h
	M	WebCore/bindings/js/JSDOMWindowCustom.cpp
	M	WebCore/bindings/js/JSHTMLAllCollection.h
	M	WebCore/bindings/js/JSDocumentCustom.cpp
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/dom/prototype-inheritance-2-expected.txt
	M	LayoutTests/fast/dom/prototype-inheritance-expected.txt
r46320 = cc7b4c4103deafff9b1fc0069ad4e87549d98161 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46320