Bug 275771
| Summary: | REGRESSION(280148@main): It regressed the score of MotionMark CanvasLines | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Canvas | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Said Abou-Hallawa
Before 280148@main, CanvasRenderingContext2DBase::fillInternal() and CanvasRenderingContext2DBase::strokeInternal() used to call Path::fastBoundingRect() only when the global filter is set. fastBoundingRect() is an expensive operation and should not be called unless its value will be used by CanvasFilterContextSwitcher::create(). CanvasLines draws all the path segments without any filter set. So calculating the fastBoundingRect() is not needed in this case.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/130319651>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/30079
EWS
Committed 280282@main (13a39723d661): <https://commits.webkit.org/280282@main>
Reviewed commits have been landed. Closing PR #30079 and removing active labels.