Bug 275643
| Summary: | Enable offline asm alt entries on linux and on debug builds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Michaud <justin> |
| Component: | JavaScriptCore | Assignee: | Justin Michaud <jmichaud> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | commit-queue, fujii.hironori, philn, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 275774 | ||
| Bug Blocks: | |||
Justin Michaud
Enable offline asm alt entries on linux and on debug builds
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Justin Michaud
Pull request: https://github.com/WebKit/WebKit/pull/29960
EWS
Committed 280250@main (36e90ed8d1ae): <https://commits.webkit.org/280250@main>
Reviewed commits have been landed. Closing PR #29960 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/130280027>
WebKit Commit Bot
Re-opened since this is blocked by bug 275774
Philippe Normand
FAILED: Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o
/usr/bin/ccache /usr/lib/sdk/llvm18/bin/clang++ -DBUILDING_GTK__=1 -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WebKitGTK-6.0\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -I/app/webkit/WebKitBuild/GTK/Release/JavaScriptCore/Headers -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/app/webkit/WebKitBuild/GTK/Release -I/app/webkit/Source/JavaScriptCore -I/app/webkit/Source/JavaScriptCore/API -I/app/webkit/Source/JavaScriptCore/assembler -I/app/webkit/Source/JavaScriptCore/b3 -I/app/webkit/Source/JavaScriptCore/b3/air -I/app/webkit/Source/JavaScriptCore/bindings -I/app/webkit/Source/JavaScriptCore/builtins -I/app/webkit/Source/JavaScriptCore/bytecode -I/app/webkit/Source/JavaScriptCore/bytecompiler -I/app/webkit/Source/JavaScriptCore/dfg -I/app/webkit/Source/JavaScriptCore/disassembler -I/app/webkit/Source/JavaScriptCore/disassembler/ARM64 -I/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis -I/app/webkit/Source/JavaScriptCore/domjit -I/app/webkit/Source/JavaScriptCore/ftl -I/app/webkit/Source/JavaScriptCore/fuzzilli -I/app/webkit/Source/JavaScriptCore/heap -I/app/webkit/Source/JavaScriptCore/debugger -I/app/webkit/Source/JavaScriptCore/inspector -I/app/webkit/Source/JavaScriptCore/inspector/agents -I/app/webkit/Source/JavaScriptCore/inspector/augmentable -I/app/webkit/Source/JavaScriptCore/inspector/remote -I/app/webkit/Source/JavaScriptCore/interpreter -I/app/webkit/Source/JavaScriptCore/jit -I/app/webkit/Source/JavaScriptCore/llint -I/app/webkit/Source/JavaScriptCore/parser -I/app/webkit/Source/JavaScriptCore/profiler -I/app/webkit/Source/JavaScriptCore/runtime -I/app/webkit/Source/JavaScriptCore/tools -I/app/webkit/Source/JavaScriptCore/wasm -I/app/webkit/Source/JavaScriptCore/wasm/js -I/app/webkit/Source/JavaScriptCore/yarr -I/app/webkit/WebKitBuild/GTK/Release/JavaScriptCore/DerivedSources -I/app/webkit/WebKitBuild/GTK/Release/JavaScriptCore/DerivedSources/inspector -I/app/webkit/WebKitBuild/GTK/Release/JavaScriptCore/DerivedSources/runtime -I/app/webkit/WebKitBuild/GTK/Release/JavaScriptCore/DerivedSources/yarr -I/app/webkit/Source/JavaScriptCore/API/glib -I/app/webkit/WebKitBuild/GTK/Release/JavaScriptCoreGLib/DerivedSources -I/app/webkit/WebKitBuild/GTK/Release/JavaScriptCoreGLib/DerivedSources/jsc -I/app/webkit/WebKitBuild/GTK/Release/JavaScriptCoreGLib/Headers -I/app/webkit/Source/JavaScriptCore/inspector/remote/glib -I/app/webkit/WebKitBuild/GTK/Release/WTF/Headers -I/app/webkit/Source/ThirdParty/libsysprof-capture -I/app/webkit/WebKitBuild/GTK/Release/bmalloc/Headers -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fno-strict-aliasing -fno-exceptions -fno-rtti -fcoroutines -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++23 -fPIC -fvisibility=hidden -MD -MT Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o -MF Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o -c /app/webkit/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
<inline asm>:9:1: error: unknown directive
9 | .alt_entry llintPCRangeStart
| ^
<inline asm>:18:1: error: unknown directive
18 | .alt_entry vmEntryToJavaScript
| ^
<inline asm>:44:1: error: unknown directive
44 | .alt_entry jsc_llint_doVMEntry__copyHeaderLoop
| ^
<inline asm>:66:1: error: unknown directive
66 | .alt_entry jsc_llint_doVMEntry__fillExtraArgsLoop
| ^
<inline asm>:77:1: error: unknown directive
77 | .alt_entry jsc_llint_doVMEntry__copyArgs
| ^
<inline asm>:85:1: error: unknown directive
85 | .alt_entry jsc_llint_doVMEntry__copyArgsLoop
| ^
<inline asm>:98:1: error: unknown directive
98 | .alt_entry jsc_llint_doVMEntry__copyArgsDone
| ^
<inline asm>:110:1: error: unknown directive
110 | .alt_entry llint_call_javascript
| ^
<inline asm>:113:1: error: symbol 'llint_call_javascript' is already defined
113 | llint_call_javascript:
| ^
<inline asm>:131:1: error: unknown directive
131 | .alt_entry vmEntryToNative
| ^
<inline asm>:157:1: error: unknown directive
157 | .alt_entry jsc_llint_0_doVMEntry__copyHeaderLoop
| ^
<inline asm>:179:1: error: unknown directive
179 | .alt_entry jsc_llint_0_doVMEntry__fillExtraArgsLoop
| ^
<inline asm>:190:1: error: unknown directive
190 | .alt_entry jsc_llint_0_doVMEntry__copyArgs
| ^
<inline asm>:198:1: error: unknown directive
198 | .alt_entry jsc_llint_0_doVMEntry__copyArgsLoop
| ^
<inline asm>:211:1: error: unknown directive
211 | .alt_entry jsc_llint_0_doVMEntry__copyArgsDone
| ^
<inline asm>:236:1: error: unknown directive
236 | .alt_entry vmEntryToYarrJIT
| ^
<inline asm>:248:1: error: unknown directive
248 | .alt_entry vmEntryCustomGetter
| ^
<inline asm>:257:1: error: unknown directive
257 | .alt_entry vmEntryCustomSetter
| ^
<inline asm>:266:1: error: unknown directive
266 | .alt_entry vmEntryHostFunction
| ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
ninja: build stopped: subcommand failed.
Fujii Hironori
It broke Windows and PlayStation Debug builds, too.