Bug 275485
| Summary: | [WPE][GTK] Bubblewrap sandbox should not kill auxiliary process when UI process terminates | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
The bubblewrap sandbox should not kill auxiliary processes when the UI process terminates. Instead, let the child process terminate cleanly. The idea here is to match the behavior of unsandboxed WebKit and flatpaked WebKit and reduce the odds of bugs going unnoticed. This will allow exit handlers to run; notably, EGL termination has historically been a source of crashes. This will also avoid subverting the purpose of the watchdog thread that crashes the web process 10 seconds after the UI process exits.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/29825
EWS
Committed 280061@main (5d324a1c159c): <https://commits.webkit.org/280061@main>
Reviewed commits have been landed. Closing PR #29825 and removing active labels.
Michael Catanzaro
Carlos Garcia discovered this doesn't actually work. I didn't actually test to ensure the web process would actually shut down cleanly.
Michael Catanzaro
Sorry, I misunderstood. Carlos is saying it works for GTK but not for WPE. That seems extremely strange, though.