Bug 27547

Summary:

expand prototype-inheritance test to cover constructors

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

27088

Attachments:

Description	Flags
patch	darin: review+

Eric Seidel (no email)

Reported 2009-07-22 10:48:46 PDT

expand prototype-inheritance test to cover constructors This catches the case (we currently have, but I'm about to fix) of document.__proto__ coming from the right window, but document.constructor coming from the wrong one.

Attachments
patch (26.88 KB, patch) 2009-07-22 10:58 PDT, Eric Seidel (no email)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-07-22 10:58:49 PDT

Created attachment 33269 [details] patch

Eric Seidel (no email)

Comment 2 2009-07-22 13:06:50 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/dom/prototype-inheritance-expected.txt M LayoutTests/fast/dom/resources/prototype-inheritance.js Committed r46234 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/cpplint_unittest.py M WebKitTools/Scripts/modules/cpplint.py r46233 = fdc13c2d6d28cc310728fb3515d100ae4bc72d9d (trunk) M LayoutTests/ChangeLog M LayoutTests/fast/dom/resources/prototype-inheritance.js M LayoutTests/fast/dom/prototype-inheritance-expected.txt r46234 = 4e0e5698c1755a2e7a2274f9f4e6fcd48deec366 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46234

Eric Seidel (no email)

Comment 3 2009-07-22 13:07:31 PDT

Thanks! Thankfully bugzilla-tool caught my lack of ChangeLog. :) I <3 bugzilla-tool

Note You need to log in before you can comment on or make changes to this bug.