Bug 275309 – Code style misses an entry about a space in empty braces, check-webkit-style checks

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kohei Asano]

check-webkit-style checks a space in every empty braces. 

We can check this for empty braces, i.e. in https://github.com/WebKit/WebKit/commit/736ea9e03ccb296098339b8766404e3c34d6ffe3.



void f() {}
struct Unit {};
union U2 {};
class U3 {};
enum U4 {};
int x {};
auto a = [] {};



$ python ./Tools/Scripts/check-webkit-style --git-index
ERROR: Tools/MiniBrowser/win/MainWindow.cpp:410:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Tools/MiniBrowser/win/MainWindow.cpp:411:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Tools/MiniBrowser/win/MainWindow.cpp:412:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Tools/MiniBrowser/win/MainWindow.cpp:413:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Tools/MiniBrowser/win/MainWindow.cpp:414:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Tools/MiniBrowser/win/MainWindow.cpp:415:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Tools/MiniBrowser/win/MainWindow.cpp:416:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Tools/MiniBrowser/win/MainWindow.cpp:424:  Missing space inside { }.  [whitespace/braces] [5]


but Code Style Guidelines misses about this rule. https://webkit.org/code-style-guidelines/#braces

[Kohei Asano]

Pull request: https://github.com/WebKit/WebKit/pull/29668

[Radar WebKit Bug Importer]

<rdar://problem/129984041>

[EWS]

Committed 280182@main (528d5d1f396a): <https://commits.webkit.org/280182@main>

Reviewed commits have been landed. Closing PR #29668 and removing active labels.