Bug 275297 – REGRESSION(279732@main): [GTK][WPE] Build fails with -DUSE_TEXTURE_MAPPER_DMABUF=OFF

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Jim Mason]

The build fails as follows:

/build/rtutils/components/desktop/webkitgtk4-dev/build/amd64/DerivedSources/WebKit/GeneratedSerializers.cpp:733:10: fatal error: WebCore/DMABufColorSpace.h: No such file or directory
  733 | #include <WebCore/DMABufColorSpace.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

[Miguel Gomez]

This is because the DMABuf headers are only included when GBM is enabled, but the DMABufObject serialization definition happens unconditionally. It should probably happen only when GBM is enabled.

[Adrian Perez]

Good find, I'll try to make a quick patch for this.

[Adrian Perez]

(In reply to Adrian Perez from comment #2)
> Good find, I'll try to make a quick patch for this.

Well, still on it... not so quick in the end. There's also a few
more issues with USE_GBM=OFF, that I am trying to solve as well.
Like for example:

/app/webkit/Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:247:28: error: no member named 'preferredBufferFormatsDidChange' in 'WebKit::WebPageProxy'
            webView.page().preferredBufferFormatsDidChange();
            ~~~~~~~~~~~~~~ ^
/usr/include/glib-2.0/gobject/gclosure.h:73:40: note: expanded from macro 'G_CALLBACK'
#define G_CALLBACK(f)                    ((GCallback) (f))
                                                       ^
/usr/include/glib-2.0/gobject/gsignal.h:515:60: note: expanded from macro 'g_signal_connect'
    g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
                                                           ^~~~~~~~~
1 error generated.

[Miguel Gomez]

Pull request: https://github.com/WebKit/WebKit/pull/32380

[Jim Mason]

(In reply to Miguel Gomez from comment #4)
> Pull request: https://github.com/WebKit/WebKit/pull/32380

Will need an analogous fix for PlatformGTK.cmake?

[Miguel Gomez]

I've tested that the PR fixes the build for WPE, but I haven't tested it for GTK. It will probably fix the DMABufColorSpace error, but there may be others, as Adrian says. Please feel free to reopen in that case.

[Jim Mason]

(In reply to Miguel Gomez from comment #6)
> I've tested that the PR fixes the build for WPE, but I haven't tested it for
> GTK. It will probably fix the DMABufColorSpace error, but there may be
> others, as Adrian says. Please feel free to reopen in that case.

Thanks, I have confirmed the revised patch resolves the issue for GTK.

[EWS]

Committed 282423@main (34bd9017f91a): <https://commits.webkit.org/282423@main>

Reviewed commits have been landed. Closing PR #32380 and removing active labels.