Bug 27528

Summary: run-webkit-lint should have --git-commit option
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1
none
Patch v2 levin: review+

Shinichiro Hamaji
Reported 2009-07-21 22:29:25 PDT
We would want to check style for local git commits.
Attachments
Patch v1 (3.70 KB, patch)
2009-07-21 22:30 PDT, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
Patch v2 (7.72 KB, patch)
2009-07-21 22:45 PDT, Shinichiro Hamaji 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2009-07-21 22:30:50 PDT
Created attachment 33240 [details] Patch v1 --- 3 files changed, 35 insertions(+), 7 deletions(-)
Shinichiro Hamaji
Comment 2 2009-07-21 22:34:48 PDT
Comment on attachment 33240 [details] Patch v1 Oops. This breaks cpplint_unittest due to lack of default argument of additional_flags. I'll modify a bit.
Shinichiro Hamaji
Comment 3 2009-07-21 22:45:21 PDT
Created attachment 33241 [details] Patch v2 --- 4 files changed, 56 insertions(+), 18 deletions(-)
David Levin
Comment 4 2009-07-21 23:36:00 PDT
Comment on attachment 33241 [details] Patch v2 > diff --git a/WebKitTools/Scripts/run-webkit-lint b/WebKitTools/Scripts/run-webkit-lint > @@ -57,6 +57,13 @@ Syntax: %(program_name)s [--verbose=#] [--output=vs7] [--filter=-x,+y,...] Shouldn't the "Syntax" line get [--git-commit=<COMMITISH>] added to it?
David Levin
Comment 5 2009-07-22 09:11:25 PDT
Comment on attachment 33241 [details] Patch v2 I'll fix the small issue that I noted above while landing.
David Levin
Comment 6 2009-07-22 14:23:58 PDT
Assign to levin for landing.
David Levin
Comment 7 2009-07-22 15:11:16 PDT
Committed as http://trac.webkit.org/changeset/46242
Note You need to log in before you can comment on or make changes to this bug.