Bug 27527

Summary:

Move call linking / repatching down from AbstractMacroAssembler into MacroAssemblerARCH classes.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
The patch	sam: review+

Gavin Barraclough

Reported 2009-07-21 19:50:05 PDT

This allows the implementation to be defined per architecture. Specifically this addresses the fact that x86-64 MacroAssembler implements far calls as a load to register, followed by a call to register. Patching the call actually requires the pointer load to be patched, rather than the call to be patched. This is implementation detail specific to MacroAssemblerX86_64, and as such is best handled there.

Attachments
The patch (9.55 KB, patch) 2009-07-21 19:50 PDT, Gavin Barraclough	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2009-07-21 19:50:47 PDT

Created attachment 33236 [details] The patch

Gavin Barraclough

Comment 2 2009-07-21 20:24:52 PDT

Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/AbstractMacroAssembler.h Sending JavaScriptCore/assembler/MacroAssemblerARM.h Sending JavaScriptCore/assembler/MacroAssemblerARMv7.h Sending JavaScriptCore/assembler/MacroAssemblerX86.h Sending JavaScriptCore/assembler/MacroAssemblerX86_64.h Sending JavaScriptCore/assembler/X86Assembler.h Transmitting file data ....... Committed revision 46209.

Note You need to log in before you can comment on or make changes to this bug.