Bug 275250
| Summary: | [Site Isolation] Do not create separate back forward items for embedded root child frames | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Charlie Wolfe <charliew> |
| Component: | WebKit Process Model | Assignee: | Charlie Wolfe <charliew> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | nham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Charlie Wolfe
Before this change, we would add a separate item to the back forward list each time an out-of-process iframe was embedded. Then, we would try to skip over these items when moving the main frame or its local children back or forward. This did not work in certain cases, like when navigating nested iframes or when navigating back to a page that contained iframes. This patch changes this so that instead, when a root child frame is embedded, we attach the created back forward items to the item that corresponds to the page it was embedded in. Then, when moving back, we reference the frame that was most recently navigated to associate it with an out-of-process iframe that may have existed on a previous back forward item.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/129391516>
Charlie Wolfe
Pull request: https://github.com/WebKit/WebKit/pull/29617
EWS
Committed 279823@main (3d354010882c): <https://commits.webkit.org/279823@main>
Reviewed commits have been landed. Closing PR #29617 and removing active labels.