Bug 27521

Summary:

Move m_context out of generator into superclass

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

27088

Attachments:

Description	Flags
patch	none
Move out into a file to fix WebKit build	none
Fix WebKit build by moving into new file	abarth: review+

Eric Seidel (no email)

Reported 2009-07-21 15:07:11 PDT

Move m_context out of generator into superclass This will reduce WebCore's code size. This will also make it easier for me to incrementally move classes over to holding an m_globalObject pointer.

Attachments
patch (9.00 KB, patch) 2009-07-21 15:09 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Move out into a file to fix WebKit build (16.03 KB, patch) 2009-07-21 16:47 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Fix WebKit build by moving into new file (16.38 KB, patch) 2009-07-21 16:49 PDT, Eric Seidel (no email)	abarth: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-07-21 15:09:59 PDT

Created attachment 33217 [details] patch

Adam Barth

Comment 2 2009-07-21 15:56:11 PDT

Comment on attachment 33217 [details] patch This looks good. Perl is super ugly.

Eric Seidel (no email)

Comment 3 2009-07-21 16:47:58 PDT

Created attachment 33227 [details] Move out into a file to fix WebKit build --- 9 files changed, 113 insertions(+), 43 deletions(-)

Eric Seidel (no email)

Comment 4 2009-07-21 16:49:56 PDT

Created attachment 33228 [details] Fix WebKit build by moving into new file --- 9 files changed, 121 insertions(+), 43 deletions(-)

Adam Barth

Comment 5 2009-07-21 17:02:00 PDT

Comment on attachment 33228 [details] Fix WebKit build by moving into new file okedoke

Eric Seidel (no email)

Comment 6 2009-07-21 17:08:29 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.gypi M WebCore/WebCore.pro M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj A WebCore/bindings/js/DOMObjectWithSVGContext.h M WebCore/bindings/js/JSEventCustom.cpp M WebCore/bindings/scripts/CodeGeneratorJS.pm Committed r46201 M WebCore/WebCore.pro M WebCore/ChangeLog M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.gypi M WebCore/bindings/scripts/CodeGeneratorJS.pm A WebCore/bindings/js/DOMObjectWithSVGContext.h M WebCore/bindings/js/JSEventCustom.cpp M WebCore/WebCore.xcodeproj/project.pbxproj r46201 = ef823b64df0e4d61afa35bb385e3fa577ac0f419 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46201

Sam Weinig

Comment 7 2009-07-21 18:52:48 PDT

Out of curiosity, what is the reason that the context can't be in the JSSVGPODTypeWrapper class?

Adam Barth

Comment 8 2009-07-21 21:50:56 PDT

(In reply to comment #7) > Out of curiosity, what is the reason that the context can't be in the > JSSVGPODTypeWrapper class? The context will eventually move to the impl, so I'm not sure it matters that much were it is in the intermediate term.

Eric Seidel (no email)

Comment 9 2009-07-21 23:58:08 PDT

(In reply to comment #7) > Out of curiosity, what is the reason that the context can't be in the > JSSVGPODTypeWrapper class? Sam is correct, that in the case of POD types, JSSVGPODTypeWrapper is the impl. For things like SVGPathSeg, those classes will have to change to hold some sort of context pointer. JSSVGPODTypeWrapper will be the "easy" case.

Note You need to log in before you can comment on or make changes to this bug.