Bug 275170
| Summary: | Consider using simd base64 encode/decode from simdutf | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | hi, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
The simdutf project, https://github.com/simdutf/simdutf, in addition to having highly optimized unicode conversions has highly optimized/tested/fuzzed base64 encode/decode implementations, importantly including support for WHATWG-forgiving base64 -> https://github.com/simdutf/simdutf?tab=readme-ov-file#base64.
simdutf is licensed under a compatible Apache-2.0 / MIT licenses, so we should consider an import.
(our current implementation is entirely scalar)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/129694621>
Yusuke Suzuki
Yes, I'm working on this right now.
Yusuke Suzuki
We already adopted simdutf for Uint8Array toBase64. I will apply fromBase64 part too (having some patch already).
Sam Weinig
Looks like Yusuke did this in https://commits.webkit.org/281035@main and https://commits.webkit.org/281899@main! Thanks!.