Bug 275168

Summary:	shadowsIgnoreTransforms should negate the vertical shadowOffset on Cocoa ports only
Product:	WebKit	Reporter:	Said Abou-Hallawa <sabouhallawa>
Component:	Layout and Rendering	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Said Abou-Hallawa

Reported 2024-06-05 10:34:16 PDT

For Cocoa ports the coordinates system is flipped (the origin is the bottom-left corner). Usually the coordinates system is unflipped by moving the origin to the top-left corner. When GraphicsContext.shadowsIgnoreTransforms() is true this means the coordinates system is still flipped. In this case the vertical shadow offset should be negated.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-06-05 10:34:30 PDT

<rdar://problem/129291752>

Said Abou-Hallawa

Comment 2 2024-06-05 10:46:41 PDT

Pull request: https://github.com/WebKit/WebKit/pull/29548

EWS

Comment 3 2024-06-19 09:08:20 PDT

Committed 280175@main (e159672b31de): <https://commits.webkit.org/280175@main> Reviewed commits have been landed. Closing PR #29548 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.