Bug 275130
| Summary: | git-webkit setup fails if you say no to creating forks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brianna Fan <bfan2> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brianna Fan
If you say no to either of those prompts, `git-webkit setup` fails. So, effectively, the script requires you to say yes to two prompts at which it allows you to say no. That doesn’t seem ideal.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brianna Fan
<rdar://problem/129174097>
Alexey Proskuryakov
It seems reasonable to ask, but the wording needs to clearly explain that the script will stop if the answer is "no", and also explain how to decide (is it just a harmless FYI, or could one expose themselves to terrible problems if they say yes?)
If it's just an FYI, perhaps we could say something to the effect of "press any key to continue, or Ctrl+C if you need to bail out for some reason that's beyond us".
Brianna Fan
Pull request: https://github.com/WebKit/WebKit/pull/29730
EWS
Committed 280044@main (efe2c1b2143c): <https://commits.webkit.org/280044@main>
Reviewed commits have been landed. Closing PR #29730 and removing active labels.