Bug 27513 – [Chromium] Linux: add static functions to FontPlatformData which allow for setting the global font rendering preferences.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Adam Langley]

Chromium Linux: add static functions to FontPlatformData which allow for setting the global font rendering preferences.

[Adam Langley]

Created attachment 33208 [details]
patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 33208 [details]
patch

> +    enum HintingLevel {
> +        Normal,
> +        None,
> +        Slight,
> +        Full,
> +    };
> +    enum Smoothing {
> +        Gray,
> +        Mono,
> +        Subpixel,
> +    };
> +    enum LCDOrder {
> +        RGB,
> +        BGR,
> +    };
> +    enum LCDOrientation {
> +        Horizontal,
> +        Vertical,
> +    };

Why not just use the Skia defined enums?  Now that I see this,
I wonder the same about the WebKit API patch I reviewed earlier.

The WebKit API has the WEBKIT_USING_SKIA define, which allows
for you to use Skia types directly.

-Darin

[Adam Langley]

Created attachment 33229 [details]
patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 33229 [details]
patch

> +    static void setHinting(SkPaint::Hinting);
> +    static void setAntiAlias(bool on);
> +    static void setSubpixelGlyphs(bool on);

nit: i think webkit style is to leave these bool parameters unnamed.

otherwise, r=me