Summary: | [Chromium] Linux: add static functions to FontPlatformData which allow for setting the global font rendering preferences. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Langley <agl> | ||||||
Component: | Layout and Rendering | Assignee: | Adam Langley <agl> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | levin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Adam Langley
2009-07-21 13:34:09 PDT
Created attachment 33208 [details]
patch
Comment on attachment 33208 [details] patch > + enum HintingLevel { > + Normal, > + None, > + Slight, > + Full, > + }; > + enum Smoothing { > + Gray, > + Mono, > + Subpixel, > + }; > + enum LCDOrder { > + RGB, > + BGR, > + }; > + enum LCDOrientation { > + Horizontal, > + Vertical, > + }; Why not just use the Skia defined enums? Now that I see this, I wonder the same about the WebKit API patch I reviewed earlier. The WebKit API has the WEBKIT_USING_SKIA define, which allows for you to use Skia types directly. -Darin Created attachment 33229 [details]
patch
Comment on attachment 33229 [details] patch > + static void setHinting(SkPaint::Hinting); > + static void setAntiAlias(bool on); > + static void setSubpixelGlyphs(bool on); nit: i think webkit style is to leave these bool parameters unnamed. otherwise, r=me |