Bug 27512 – Test for QWebFrame::hasSetFocus() is trying to use a not defined resource.

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Andre Pedralho]

There is no frametest folder and qwebframe.qrc does not specify where to find it.

tst_qwebframe.cpp:
void tst_QWebFrame::hasSetFocus()
{
(...)
   QUrl url = QUrl("qrc:///frametest/iframe.html");
   _page->mainFrame()->load(url);
(...)
}

qwebframe.qrc:
<!DOCTYPE RCC><RCC version="1.0">
<qresource prefix="/">
<file>image.png</file>
<file>style.css</file>
</qresource>
</RCC>

[Andre Pedralho]

Created attachment 33207 [details]
Copied resources from qwebpage tests and added the references to the qwebframe.qrc.

[Antonio Gomes]

we are duping the resources used in qwebframe and qwebpage. should not we make them to share the resource ?

[Adam Treat]

Comment on attachment 33207 [details]
Copied resources from qwebpage tests and added the references to the qwebframe.qrc.

As tonikitoo pointed out, we shouldn't dupe the resources, but rather share them.

[Andre Pedralho]

(In reply to comment #3)
> (From update of attachment 33207 [details])
> As tonikitoo pointed out, we shouldn't dupe the resources, but rather share
> them.

Agree with that, however "the listed resource files must be located in the same directory as the .qrc file, or one of its subdirectories" according to the Qt  resources docs.

As there are two different directories to QWebFrame and to QWebPage tests the only way to share the resources would be to have a pool of resources in WebKit/qt/tests/'resources'/ with the qrc files related to both tests.

I mean:

ls WebKit/qt/tests/:
benchmarks  qwebelement  qwebframe (...) qwebpage  qwebview  RESOURCES tests.pro

ls WebKit/qt/tests/resources:
FRAMETEST image.png qwebframe.qrc style.css tst_qwebpage.qrc

IMHO, the best solution here is to create separated resources to each tests, maybe duplicating it.

[Andre Pedralho]

Hausmann, we need your opinion to find the best solution here. Can you help us?

[Simon Hausmann]

Hmmm, another option, potentially simpler, would be to replace the use of the resources for html with data urls. What do you think?

[Antonio Gomes]

simon, he has done so for this renderContents removal patch (not uploaded yet) ... and it looks pretty nice. and it would work here too, imho

ps: we should "invalid" this one instead of mark as "fixed" ?

[Andre Pedralho]

Reopening as the bug itself still there and might be fixed with the solution proposed in comment #6.

[Andre Pedralho]

Created attachment 33445 [details]
Using setHtml methods to define the test web page instead of external resources.

[Andre Pedralho]

Created attachment 33560 [details]
Using QSignalSpy to control whether a load finished signal has been emited instead of just wait for some miliseconds.

Marking old patch obsolete as per suggestions in IRC.

[Simon Hausmann]

Comment on attachment 33560 [details]
Using QSignalSpy to control whether a load finished signal has been emited instead of just wait for some miliseconds.

r=me. Thanks

[Simon Hausmann]

Landed in r46475