Bug 275100
| Summary: | CanvasBase owns a ImageBuffer that belongs to the CanvasRenderingContext | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | Canvas | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | sabouhallawa, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 274750, 275105, 275144, 275201, 275563, 275902, 277478 | ||
| Bug Blocks: | 273622 | ||
Kimmo Kinnunen
CanvasBase owns a ImageBuffer that belongs to the CanvasRenderingContext
This is a problem because only CanvasRenderingContext2DBase really uses the ImageBuffer. Others would be better performing if the CanvasBase didn't have a ImageBuffer, rather the buffer was asked from the context.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/129208981>
Simon Fraser (smfr)
> the buffer was asked from the context
This seems backwards. The buffer vends the context.
Kimmo Kinnunen
(In reply to Simon Fraser (smfr) from comment #2)
> > the buffer was asked from the context
> This seems backwards. The buffer vends the context.
The intention was to say "the |drawing or display] buffer copy was asked from the [canvas rendering] context". In this context "buffer vends the context" doesn't make sense.
The specific variant of canvas rendering context should return the rendering results image, it is private logic of said rendering type.
The specific variant of canvas rendering context should manage the drawing buffer backing store in the manner it needs to manage it.