Bug 275027
| Summary: | `value` attribute on HTMLTextAreaElement should treat `null` as emptyString | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | akeerthi, annevk, cdumez, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's patches, I came across another potential merge:
Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/1230173
WebKit Source: https://searchfox.org/wubkat/rev/4eb5890b06fef636c92e25930b303010b12184f6/Source/WebCore/html/HTMLTextAreaElement.cpp#365
auto normalizedValue = newValue.isNull() ? emptyString() : makeStringBySimplifyingNewLines(newValue);
Changed to:
auto normalizedValue = makeStringBySimplifyingNewLines(newValue);
Just wanted to raise to get input.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/129470548>
Anne van Kesteren
Our IDL appears correct and this branch is at worst redundant, but it's a bit unclear given that ::setValueCommon is not just called from ::setValue. You'd have to figure out if the other callers of ::setValueCommon need this or not.