Bug 27502

Summary: Web Inspector: Add ability to evaluate selection while on break point.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, timothy
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch timothy: review+

Pavel Feldman
Reported 2009-07-21 08:10:35 PDT
While on a break point, there should be a way to evaluate selected text in the source frame. There should be a separate request to evaluate text on hover, but it is beyond the scope of this one. I'd suggest the following user scenario: 1. User hits a breakpoint 2. User selects text he wants to evaluate 3. Presses Meta + Shift + E shortcut (or optionally chooses item in Popup menu?) 4. Result is printed in the console.
Attachments
patch (3.59 KB, patch)
2009-07-21 08:19 PDT, Pavel Feldman
timothy: review+
Pavel Feldman
Comment 1 2009-07-21 08:19:02 PDT
Timothy Hatcher
Comment 2 2009-07-21 09:16:48 PDT
We really need a way to change the context menu from JS for the Inspector so we can add items like this for discoverability. Bug 26881 and bug 22147.
Timothy Hatcher
Comment 3 2009-07-21 09:22:29 PDT
Comment on attachment 33177 [details] patch > + var shortcut = WebInspector.KeyboardShortcut.makeKey( > + 69 /* 'E' */, > + platformSpecificModifier | WebInspector.KeyboardShortcut.Modifiers.Shift); I think that would be fine and more readable on one line. Talk to Sam Weinig, he has a patch (maybe landed) that will let us add "evaluate on hover".
Pavel Feldman
Comment 4 2009-07-21 09:51:23 PDT
Sending WebCore/ChangeLog Sending WebCore/inspector/front-end/SourceFrame.js Transmitting file data .. Committed revision 46176.
Note You need to log in before you can comment on or make changes to this bug.