Bug 274830
| Summary: | [Skia] Fix corner cases involving drawing shadows when ImageBitmap is accelerated | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pawel Lampe <plampe> |
| Component: | WPE WebKit | Assignee: | Pawel Lampe <plampe> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, webkit-bug-importer |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 268972 | ||
Pawel Lampe
See https://github.com/WebKit/WebKit/commit/ab81e7f867ac35e5208bea45000caea21b7c5e9f
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Pawel Lampe
See 1) from https://bugs.webkit.org/show_bug.cgi?id=273239#c2 as well
Pawel Lampe
It turns out, in this case we're drawing GPU-backed image on CPU-backed surface with filter. The resulting operation does nothing, as filter erases everything as we're ending up here: https://github.com/WebKit/WebKit/blob/be3ab121b14a9074bdc6031125646c295fe7d1f4/Source/ThirdParty/skia/src/core/SkSpecialImage.cpp#L195
This fiddle showcases the problem: https://fiddle.skia.org/c/3bca2eca37709b84b7afd7bc5ac88321
Skia developers suggested to address this issue on WebKit end.
Pawel Lampe
Pull request: https://github.com/WebKit/WebKit/pull/30186
EWS
Committed 280408@main (5d0a3ef57206): <https://commits.webkit.org/280408@main>
Reviewed commits have been landed. Closing PR #30186 and removing active labels.