diff_parser should accept lines without trailing \n

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Shinichiro Hamaji]

It would be better to normalize the input lines by removing trailing newlines to accept both patch.splitlines() and file object.

[Shinichiro Hamaji]

Created attachment 33145 [details]
Patch v1


---
 3 files changed, 29 insertions(+), 2 deletions(-)

[David Levin]

Comment on attachment 33145 [details]
Patch v1

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog

> +
> +        Normalize the input lines by removing a trailing newline.
> +        Also, add a case for unittest for newly added files.
I think this reads better: "Also, add a case to the unittest for newly added files."

fwiw, it is best to keep your patches focused on one thing and this does a bit more, so the bug doesn't reflect what is being done. However, it is all rather simple and you do describe it, so no need to break it up this time.

[David Levin]

Committed as http://trac.webkit.org/changeset/46164