Bug 274827

Summary: REGRESSION(2.45.1/2.45.2): [GTK] All PNG images look jagged
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Patrick Griffis <pgriffis>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The logo
none
Before (2.44)
none
After (2.45)
none
Second image
none
Screenshot of second image displayed in Newsflash none

Michael Catanzaro
Reported 2024-05-29 05:22:19 PDT
Created attachment 471535 [details] The logo The attached PNG image is used by Red Hat for its Google account logo. Since 2.45.1 or 2.45.2, the logo looks bad when rendered in the upper right hand corner of Google domains like calendar.google.com or mail.google.com. I'm attaching the image itself, a Before screenshot showing that it's rendered fine in 2.44, and an After screenshot showing it's rendered badly in 2.45. It might be related to the switch to skia. Note: the image is named "logo.gif" in the grand web tradition of using misleading file extensions for images. It's a PNG.
Attachments
The logo (4.84 KB, image/gif)
2024-05-29 05:22 PDT, Michael Catanzaro 		no flags
Details
Before (2.44) (7.39 KB, image/png)
2024-05-29 05:23 PDT, Michael Catanzaro 		no flags
Details
After (2.45) (7.83 KB, image/png)
2024-05-29 05:23 PDT, Michael Catanzaro 		no flags
Details
Second image (200.95 KB, image/jpeg)
2024-05-29 06:22 PDT, Michael Catanzaro 		no flags
Details
Screenshot of second image displayed in Newsflash (244.06 KB, image/png)
2024-05-29 06:23 PDT, Michael Catanzaro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2024-05-29 05:23:10 PDT
Created attachment 471536 [details] Before (2.44)
Michael Catanzaro
Comment 2 2024-05-29 05:23:22 PDT
Created attachment 471537 [details] After (2.45)
Michael Catanzaro
Comment 3 2024-05-29 06:22:48 PDT
Created attachment 471539 [details] Second image Here's a second image. This one is only conditionally broken. It displays fine when loaded in Epiphany on https://www.vox.com/money/352116/whats-really-happening-to-grocery-prices-right-now. But if you display it in Newsflash, it looks bad. It's strange that the result is different in the two applications. My first guess was that it displays badly at small sizes, but that doesn't seem to be correct; it looks fine at small sizes in Epiphany, and still looks bad at bigger sizes in Newsflash. Newsflash must be doing something differently. (Newsflash is supposed to be using WebKitGTK 2.44.2, but it's currently using 2.45.2 because I messed up and upgraded the GNOME 46 runtime to 2.45.2 by mistake.)
Michael Catanzaro
Comment 4 2024-05-29 06:23:29 PDT
Created attachment 471540 [details] Screenshot of second image displayed in Newsflash
Michael Catanzaro
Comment 5 2024-05-29 10:39:42 PDT
Finally I've noticed this bug in the reddit.com logo. That's by far the easiest reproducer. Just go to reddit.com and note that the logo looks bad.
Michael Catanzaro
Comment 6 2024-05-29 12:43:08 PDT
Another easy reproducer: https://discourse.gnome.org/
Michael Catanzaro
Comment 7 2024-07-13 07:54:34 PDT
Seems like all images on all websites are affected by this issue.
Patrick Griffis
Comment 8 2024-08-08 08:53:31 PDT
Pull request: https://github.com/WebKit/WebKit/pull/31895
EWS
Comment 9 2024-08-20 08:34:56 PDT
Committed 282492@main (1efcb4f3b8fb): <https://commits.webkit.org/282492@main> Reviewed commits have been landed. Closing PR #31895 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.