Bug 274817

Summary:

[git-webkit pr] ERROR: Unexpected diff format when parsing a chunk

Product:

WebKit

Reporter:

Karl Dubost <karlcow>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=240516

Attachments:

Description	Flags
diff compared to main	none

Karl Dubost

Reported 2024-05-28 21:23:55 PDT

I'm getting this error message. This is not blocking, but this is definitely obscure. % git webkit pr From github.com:WebKit/WebKit * branch main -> FETCH_HEAD Current branch eng/Re-Import-htmlcanvas-WPT is up to date. ERROR: Unexpected diff format when parsing a chunk: '100" height="' ERROR: Unexpected diff format when parsing a chunk: '100"><p class="fallback">FAIL (fallback content)</p></canvas>' Total errors found: 0 in 1036 files Pushing to fork, which is classified as a public remote … Previously Bug 240516 Maybe it would help if it would say which file it is complaining about.

Attachments
diff compared to main (215.74 KB, application/zip) 2024-06-06 05:22 PDT, Karl Dubost	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-06-04 21:24:42 PDT

<rdar://problem/129262472>

Sam Sneddon [:gsnedders]

Comment 2 2024-06-06 04:59:18 PDT

We'll need to know what the diff actually being processed is, because otherwise we'll have no way to figure out what's going wrong with parsing it? Could you give us the output of `git diff --binary --no-color --no-ext-diff --full-index --no-renames` for whatever the range being diffed is (whatever `main..eng/Re-Import-htmlcanvas-WPT` was when you filed this issue)?

Karl Dubost

Comment 3 2024-06-06 05:22:52 PDT

Created attachment 471608 [details] diff compared to main % python3 -V Python 3.11.7 % /usr/bin/python3 -V Python 3.9.6 % ruby -v ruby 2.6.10p210 (2022-04-12 revision 67958) [universal.arm64e-darwin24] I don't have the feeling this is dependent of the state of main. This is coming from ``` diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/canvas-host/2d.canvas.host.size.attributes.parse.whitespace.html b/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/canvas-host/2d.canvas.host.size.attributes.parse.whitespace.html new file mode 100644 index 0000000000000000000000000000000000000000..79e81c1020a85279ee119ebd2757c32bf89c10cb --- /dev/null +++ b/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/canvas-host/2d.canvas.host.size.attributes.parse.whitespace.html @@ -0,0 +1,32 @@ +<!DOCTYPE html> + +<title>Canvas test: 2d.canvas.host.size.attributes.parse.whitespace</title> +<script src="/resources/testharness.js"></script> +<script src="/resources/testharnessreport.js"></script> +<script src="/html/canvas/resources/canvas-tests.js"></script> +<link rel="stylesheet" href="/html/canvas/resources/canvas-tests.css"> +<body class="show_output"> + +<h1>2d.canvas.host.size.attributes.parse.whitespace</h1> +<p class="desc">Parsing of non-negative integers</p> + + +<p class="output">Actual output:</p> +<canvas id="c" class="output" width=" + 100" height=" + 100"><p class="fallback">FAIL (fallback content)</p></canvas> +<p class="output expectedtext">Expected output:<p><img src="2d.canvas.host.size.attributes.parse.whitespace.png" class="output expected" id="expected" alt=""> +<ul id="d"></ul> +<script> +var t = async_test("Parsing of non-negative integers"); +_addTest(function(canvas, ctx) { + + _assertSame(canvas.width, 100, "canvas.width", "100"); + _assertSame(canvas.height, 100, "canvas.height", "100"); + _assertSame(window.getComputedStyle(canvas, null).getPropertyValue("width"), "100px", "window.getComputedStyle(canvas, null).getPropertyValue(\"width\")", "\"100px\""); + _assertSame(canvas.getAttribute('width'), '\r\n\t\x0c100', "canvas.getAttribute('width')", "'\\r\\n\\t\\x0c100'"); + _assertSame(canvas.getAttribute('height'), '\r\n\t\x0c100', "canvas.getAttribute('height')", "'\\r\\n\\t\\x0c100'"); + +}); +</script> + ``` LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/canvas-host/2d.canvas.host.size.attributes.parse.whitespace.html It contains: <canvas id="c" class="output" width=" 100" height=" 100"><p class="fallback">FAIL (fallback content)</p></canvas> if I check the character into the characters table, I get U+0020 SPACE which is indeed in https://github.com/web-platform-tests/wpt/blob/0c59636522/html/canvas/element/canvas-host/2d.canvas.host.size.attributes.parse.whitespace.html

Karl Dubost

Comment 4 2024-06-06 15:11:24 PDT

Ah the character is not visible in the comments, but that's the character just before the 100

Note You need to log in before you can comment on or make changes to this bug.