Bug 274815
| Summary: | import-w3c-tests doesn't delete some files with space in them | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, gsnedders, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Karl Dubost
In the process of re-importing WPT canvas test.
% import-w3c-tests -t web-platform-tests/html/canvas
with Upstream commit: https://github.com/web-platform-tests/wpt/commit/fd2e974a4fcad4993ab141b7f4d48484a09fec1f
% grep "single argument" import-tests-log.txt
Deleting file removed from the W3C repo: /LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.html
Deleting file removed from the W3C repo: /LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.worker.js
Deleting file removed from the W3C repo: /LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.html
Then running the tests with
% run-webkit-tests --no-build imported/w3c/web-platform-tests/html/canvas
% grep "single argument" run-tests-log.txt
[2806/3220] imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.worker.html failed unexpectedly (text diff)
Writing new expected result "platform/mac/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.worker-expected.png"
[62/63] imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.worker.html failed unexpectedly (text diff, -expected.png was missing)
imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.worker.html [ Failure ]
So it didn't remove all the files which it said it had removed.
Let's see
% find LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects | grep "single argument"
LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.worker-expected.txt
LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.worker.html
It removed
LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.worker.js
but these files have not been removed:
LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single\ argument.worker-expected.txt
LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.single argument.worker.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/128914755>
Sam Sneddon [:gsnedders]
This is fundamentally tied to the fact that we don't support tests with spaces in their names, I think, but needs further investigation.
Ahmad Saleem
@Sam - will this be fixed with your change? - https://github.com/WebKit/WebKit/commit/99cb6b1f2f9e2885a54a5ade9b5d0a3073f5e398
Sam Sneddon [:gsnedders]
(In reply to Ahmad Saleem from comment #3)
> @Sam - will this be fixed with your change? -
> https://github.com/WebKit/WebKit/commit/
> 99cb6b1f2f9e2885a54a5ade9b5d0a3073f5e398
No, totally unrelated.