Bug 27479

Summary: Guard access to installedMediaEngines()[0]
Product: WebKit Reporter: Adam Langley <agl>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch
mjs: review+
patch eric: review+

Adam Langley
Reported 2009-07-20 19:25:43 PDT
Else where in the file, installedMediaEngines is always checked for being empty because access. This patch adds a case which missed that check. This triggered a crash in Chromium: http://www.yakeze.com/chat/example-chromium-crash/ However, I've been unable to reduce the reproduction, so there's no layout test.
Attachments
patch (1.55 KB, patch)
2009-07-20 19:26 PDT, Adam Langley 		mjs: review+
DetailsFormatted DiffDiff
patch (2.58 KB, patch)
2009-07-20 19:55 PDT, Adam Langley 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2009-07-20 19:26:38 PDT
Created attachment 33136 [details] patch
Maciej Stachowiak
Comment 2 2009-07-20 19:53:21 PDT
Comment on attachment 33136 [details] patch r=me
Adam Langley
Comment 3 2009-07-20 19:55:05 PDT
Created attachment 33138 [details] patch
Adam Langley
Comment 4 2009-07-20 19:55:43 PDT
(eric helped me find a reduction and write a layout test)
Eric Seidel (no email)
Comment 5 2009-07-20 19:57:17 PDT
Comment on attachment 33138 [details] patch Ok. A coupel things to fix when landing. The layout test should self-document (i.e. say something like: "PASSED -- crash using Audio with no installed engines bug 27479") The test needs a -expected.txt file from a layout tests run. empty.wav belongs in the resources/ subdirectory. You can fix those when landing. Thanks!
Note You need to log in before you can comment on or make changes to this bug.