Bug 274767
| Summary: | REGRESSION(279341@main): Minibrowser crashes if schema doesn't contain 'color-scheme' | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | WebKitGTK | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego Pino
In Playwright, after 279341@main, there are several tests failing with the following error:
```
<launching> /home/pwuser/playwright-browsers/browser_patches/webkit/pw_run.sh --inspector-pipe --user-data-dir=/tmp/playwright-test-DxSUjl about:blank
<launched> pid=369127
[pid=369127][err]
[pid=369127][err] (MiniBrowser:369136): WARNING : 06:06:45.951: 2D canvas acceleration not supported, webkit_settings_set_enable_2d_canvas_acceleration does nothing
[pid=369127][err]
[pid=369127][err] (MiniBrowser:369136): GLib-GIO-ERROR **: 06:06:46.350: Settings schema 'org.gnome.desktop.interface' does not contain a key named 'color-scheme'
[pid=369127][err] /home/pwuser/playwright-browsers/browser_patches/webkit/pw_run.sh: line 24: 369136 Trace/breakpoint trap WEBKIT_FORCE_COMPLEX_TEXT="1" "$MINIBROWSER" "$@"
[pid=369127] <process did exit: exitCode=133, signal=null>
[pid=369127] starting temporary directories cleanup
[pid=369127] finished temporary directories cleanup
```
It's necessary to check whether the schema contains 'color-scheme' before calling `g_settings_set_enum(interfaceSettings, "color-scheme")`.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Diego Pino
Pull request: https://github.com/webkit/webkit/pull/29166
EWS
Committed 279371@main (f22da2434a23): <https://commits.webkit.org/279371@main>
Reviewed commits have been landed. Closing PR #29166 and removing active labels.