Bug 27445

Summary:

Coding style fixes

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

hausmann, kenneth, manyoso

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Codign style fixes for the Qt sources	eric: review+

Kenneth Rohde Christiansen

Reported 2009-07-20 07:17:57 PDT

Created attachment 33082 [details] Codign style fixes for the Qt sources Fix Qt code to follow the WebKit Coding Style. Compiles and didn't affect the results of the layout tests

Attachments
Codign style fixes for the Qt sources (119.66 KB, patch) 2009-07-20 07:17 PDT, Kenneth Rohde Christiansen	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kenneth Rohde Christiansen

Comment 1 2009-07-20 07:21:52 PDT

Thsi patch doesn't fix all misplaces * and &, as the cpplint tool doesn't check for that yet.

Eric Seidel (no email)

Comment 2 2009-07-20 14:51:23 PDT

Comment on attachment 33082 [details] Codign style fixes for the Qt sources FANTASTIC! There are still style errors here. But I guess the tool doesn't catch those yet.

Kenneth Rohde Christiansen

Comment 3 2009-07-21 05:34:25 PDT

Landed in 46170

Note You need to log in before you can comment on or make changes to this bug.