Bug 27442

Summary: [GTK] Fully separate Pango and FreeType font backends
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bfulgham, eric, gustavo, mrobinson, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch to split FontPlatformData into a Gtk and Pango variant
none
Separate the font backends none

Jan Alonzo
Reported 2009-07-20 04:00:26 PDT
The split will make the respective files clean of #ifdefs and it makes it easier to update the respective Gtk font backends. Patch coming next..
Attachments
patch to split FontPlatformData into a Gtk and Pango variant (13.25 KB, patch)
2009-07-20 04:03 PDT, Jan Alonzo 		no flags
DetailsFormatted DiffDiff
Separate the font backends (26.71 KB, patch)
2010-09-14 16:14 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2009-07-20 04:03:52 PDT
Created attachment 33078 [details] patch to split FontPlatformData into a Gtk and Pango variant
Eric Seidel (no email)
Comment 2 2009-08-07 12:51:41 PDT
Comment on attachment 33078 [details] patch to split FontPlatformData into a Gtk and Pango variant Your changelog needs more detail. You need to say "why". What are these files used for? Is the gtk one used anymore? Why do we have 2 just for one port? Why isn't the gtk one called FontPlatformDataFreeType?
Martin Robinson
Comment 3 2010-09-14 15:57:26 PDT
This change has become important as work begins once again on the FreeType backend. I'd like to make sure that any changes made there do not break the Pango backend. Additionally, the GTK+ port may deprecate or remove the Pango backend entirely and this change also prepares for that eventuality. Finally, this change takes a big machete to the confusing #ifdef jungle living in platform/graphics/cairo.
Martin Robinson
Comment 4 2010-09-14 16:14:14 PDT
Created attachment 67617 [details] Separate the font backends
Martin Robinson
Comment 5 2010-09-14 16:15:47 PDT
Here's some overview of the current font situation for Cairo and WebKitGTK+: http://trac.webkit.org/wiki/WebKitGTKFonts
Xan Lopez
Comment 6 2010-09-15 12:30:15 PDT
Comment on attachment 67617 [details] Separate the font backends OK, this seems sane.
Martin Robinson
Comment 7 2010-09-15 12:53:19 PDT
Committed r67567: <http://trac.webkit.org/changeset/67567>
WebKit Review Bot
Comment 8 2010-09-15 13:44:10 PDT
http://trac.webkit.org/changeset/67567 might have broken GTK Linux 32-bit Release
Note You need to log in before you can comment on or make changes to this bug.