Bug 274367
| Summary: | `textarea` should not reset the caret position when it is focused by sequential focus navigation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Forms | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cdumez, karlcow, lwarlow, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=244976 | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another failing test case (already in tree with failed expectations).
Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/281b9124b31f6aa3c8030f06d25bef969c3964d5
WebKit Source: https://github.com/WebKit/WebKit/blob/dbcbbe87dd98b259cf8815a53c9bc7276892de6f/Source/WebCore/html/HTMLTextAreaElement.cpp#L227
Changing to following make us align and pass failing tests:
void HTMLTextAreaElement::updateFocusAppearance(SelectionRestorationMode restorationMode, SelectionRevealMode revealMode)
{
if ((restorationMode == SelectionRestorationMode::RestoreOrSelectAll || restorationMode == SelectionRestorationMode::SelectAll) && hasCachedSelection())
restoreCachedSelection(revealMode, Element::defaultFocusTextStateChangeIntent());
}
___
Just wanted to raise so we can track and fix these issues.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/128762719>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/30303