Bug 27429

Summary:

add gdom.h "convenience" header as part of GObject bindings

Product:

WebKit

Reporter:

Luke Kenneth Casson Leighton <lkcl>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

16401, 27430

Attachments:

Description	Flags
gdom.h developer convenience header	eric: review-
adds copyright notice and license	eric: review+, abarth: commit-queue-

Description Luke Kenneth Casson Leighton 2009-07-19 14:39:04 PDT

this is part of a series of patches splitting down #16401
under an agreement suggested by david.

gdom.h is a convenience header file that, by rights, should be auto-generated... but isn't yet.  entertaining as it is to force people to #include over 350 header files, they might not be amused.  hence the purpose of gdom.h.  like they say on braniac "we do these things... so they don't have to..."

Comment 1 Luke Kenneth Casson Leighton 2009-07-19 14:42:27 PDT

Created attachment 33058 [details]
gdom.h developer convenience header

should be auto-generated, but isn't.  auto-generation can be considered a luxury for another time.

Comment 2 Eric Seidel (no email) 2009-07-31 20:02:34 PDT

Comment on attachment 33058 [details]
gdom.h developer convenience header

Since I assume this is API for you all, you're welcome to name it however you like.  It does need a license header though.  r- for the lack of license, otherwise it looks fine.

You should also fix your name from "lkcl" to your full name.

Comment 3 Luke Kenneth Casson Leighton 2009-08-03 02:21:57 PDT

(In reply to comment #2)
> (From update of attachment 33058 [details])
> Since I assume this is API for you all, you're welcome to name it however you
> like.  It does need a license header though.  

 ahh, yes - whoops, i created it through grep "DerivedSources/gdom*.h" gdom | sort | uniq

 :)

> r- for the lack of license,
> otherwise it looks fine.
> 
> You should also fix your name from "lkcl" to your full name.

 yes.  sorry.  that's now done across all 15 patches but wasn't at the time.

Comment 4 Luke Kenneth Casson Leighton 2009-08-07 10:15:44 PDT

Created attachment 34288 [details]
adds copyright notice and license

Comment 5 Eric Seidel (no email) 2009-08-07 10:21:12 PDT

Comment on attachment 34288 [details]
adds copyright notice and license

Looks fine.

Comment 6 Adam Barth 2009-08-07 17:57:57 PDT

Comment on attachment 34288 [details]
adds copyright notice and license

commit-queue can't land this because the ChangeLog entry isn't at the top of the file.

Comment 7 Eric Seidel (no email) 2009-08-12 15:22:06 PDT

Closing out GDOM bugs.  Someone else will need to take these on later.  See my email to webkit-dev on the subject.