Bug 274232 – Regression(276114@main) Crash under WebCore::constructAndPrepareStatement

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Chris Dumez]

Crash under WebCore::constructAndPrepareStatement since 276114@main:
```
Thread 5 Crashed::   Dispatch queue: com.apple.WebKit.Storage.persistent
4   WebCore                       	       0x199765918 WTF::Lock::lock() + 0
5   WebCore                       	       0x199765918 WTF::Locker<WTF::Lock, void>::Locker(WTF::Lock&)
6   WebCore                       	       0x199765918 WTF::Locker<WTF::Lock, void>::Locker(WTF::Lock&) + 0
7   WebCore                       	       0x199765918 WebCore::constructAndPrepareStatement(WebCore::SQLiteDatabase&, char const*, unsigned long) + 56
8   WebCore                       	       0x199765804 WebCore::SQLiteDatabase::prepareHeapStatement(WTF::ASCIILiteral) + 80
9   WebKit                        	       0x19c26bc7c WebKit::SQLiteStorageArea::cachedStatement(WebKit::SQLiteStorageArea::StatementType) + 224
10  WebKit                        	       0x19c26b55c WebKit::SQLiteStorageArea::setItem(WTF::ObjectIdentifierGeneric<IPC::Connection::UniqueIDType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaImplIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits>, WTF::String&&, WTF::String&&, WTF::String const&) + 564
11  WebKit                        	       0x19c26a790 WebKit::NetworkStorageManager::setItem(IPC::Connection&, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaImplIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits>, WTF::String&&, WTF::String&&, WTF::String&&, WTF::CompletionHandler<void (bool, WTF::HashMap<WTF::String, WTF::String, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTableTraits>&&)>&&) + 668
12  WebKit                        	       0x19c26a428 auto void IPC::callMemberFunction<WebKit::NetworkStorageManager, WebKit::NetworkStorageManager, void (IPC::Connection&, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaImplIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits>, WTF::String&&, WTF::String&&, WTF::String&&, WTF::CompletionHandler<void (bool, WTF::HashMap<WTF::String, WTF::String, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTableTraits>&&)>&&), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebKit::StorageAreaIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaImplIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits>, WTF::String, WTF::String, WTF::String>, void (bool, WTF::HashMap<WTF::String, WTF::String, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTableTraits>&&)>(WebKit::NetworkStorageManager*, void (WebKit::NetworkStorageManager::*)(IPC::Connection&, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaImplIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits>, WTF::String&&, WTF::String&&, WTF::String&&, WTF::CompletionHandler<void (bool, WTF::HashMap<WTF::String, WTF::String, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTableTraits>&&)>&&), IPC::Connection&, std::__1::tuple<WTF::ObjectIdentifierGeneric<WebKit::StorageAreaIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaImplIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits>, WTF::String, WTF::String, WTF::String>&&, WTF::CompletionHandler<void (bool, WTF::HashMap<WTF::String, WTF::String, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTableTraits>&&)>&&)::'lambda'(auto&&...)::operator()<WTF::ObjectIdentifierGeneric<WebKit::StorageAreaIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::ObjectIdentifierGeneric<WebKit::StorageAreaImplIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits>, WTF::String, WTF::String, WTF::String>(auto&&...) const + 24
```

[Chris Dumez]

<rdar://128126495>

[Chris Dumez]

Pull request: https://github.com/WebKit/WebKit/pull/28625

[EWS]

Committed 278845@main (2143a0b27cbd): <https://commits.webkit.org/278845@main>

Reviewed commits have been landed. Closing PR #28625 and removing active labels.