Bug 274178

Summary: AX: ActiveElementChanged notifications for combobox should target the combobox in question, not its controlled or owned element.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, dm_mazzoni, ews-watchlist, jcraig, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2024-05-14 12:59:11 PDT
.
Attachments
Patch (19.31 KB, patch)
2024-05-14 13:02 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (20.28 KB, patch)
2024-05-15 06:49 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (20.45 KB, patch)
2024-05-15 10:58 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-05-14 12:59:22 PDT
<rdar://problem/128083384>
Andres Gonzalez
Comment 2 2024-05-14 13:02:10 PDT
Created attachment 471405 [details] Patch
Andres Gonzalez
Comment 3 2024-05-15 06:49:51 PDT
Created attachment 471414 [details] Patch
Andres Gonzalez
Comment 4 2024-05-15 10:58:45 PDT
Created attachment 471416 [details] Patch
Dominic Mazzoni
Comment 5 2024-05-15 15:46:00 PDT
Comment on attachment 471416 [details] Patch I think this will be a very worthwhile simplification!
EWS
Comment 6 2024-05-15 16:59:34 PDT
dm_mazzoni@apple.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 471416 [details] from commit queue.
Tyler Wilcock
Comment 7 2024-05-15 17:31:41 PDT
Thanks for reviewing this Dominic! It looks good to me too, I'll remove your r+ so I can add my own to make EWS happy.
EWS
Comment 8 2024-05-16 04:45:43 PDT
Committed 278858@main (62d20f512eb9): <https://commits.webkit.org/278858@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471416 [details].
Note You need to log in before you can comment on or make changes to this bug.